maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Alerting] Track deprecated configs (#113015) (#114147)

Browse source 
* Track deprecated configs

* PR feedback

* Be more careful

* Add test back in

* Fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/actions/server/index.test.ts
This commit is contained in:
Chris Roberson 2021-10-06 15:24:16 -04:00 committed by GitHub
parent 31053f09e1
commit 1916ab4d43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
x-pack/plugins/actions/server/index.ts
View file

@ -64,7 +64,8 @@ export const config: PluginConfigDescriptor<ActionsConfig> = {
if (
customHostSettings.find(
(customHostSchema: CustomHostSettings) =>
!!customHostSchema.ssl && !!customHostSchema.ssl.rejectUnauthorized
customHostSchema.hasOwnProperty('ssl') &&
customHostSchema.ssl?.hasOwnProperty('rejectUnauthorized')
)
) {
addDeprecation({
@ -82,11 +83,18 @@ export const config: PluginConfigDescriptor<ActionsConfig> = {
],
},
});
return {
unset: [
{
path: `xpack.actions.customHostSettings.ssl.rejectUnauthorized`,
},
],
};
}
},
(settings, fromPath, addDeprecation) => {
const actions = get(settings, fromPath);
if (!!actions?.rejectUnauthorized) {
if (actions?.hasOwnProperty('rejectUnauthorized')) {
addDeprecation({
message:
`"xpack.actions.rejectUnauthorized" is deprecated. Use "xpack.actions.verificationMode" instead, ` +
@ -101,11 +109,18 @@ export const config: PluginConfigDescriptor<ActionsConfig> = {
],
},
});
return {
unset: [
{
path: `xpack.actions.rejectUnauthorized`,
},
],
};
}
},
(settings, fromPath, addDeprecation) => {
const actions = get(settings, fromPath);
if (!!actions?.proxyRejectUnauthorizedCertificates) {
if (actions?.hasOwnProperty('proxyRejectUnauthorizedCertificates')) {
addDeprecation({
message:
`"xpack.actions.proxyRejectUnauthorizedCertificates" is deprecated. Use "xpack.actions.proxyVerificationMode" instead, ` +
@ -120,6 +135,13 @@ export const config: PluginConfigDescriptor<ActionsConfig> = {
],
},
});
return {
unset: [
{
path: `xpack.actions.proxyRejectUnauthorizedCertificates`,
},
],
};
}
},
(settings, fromPath, addDeprecation) => {

3
x-pack/plugins/task_manager/server/index.ts
View file

@ -41,6 +41,9 @@ export type {
export const config: PluginConfigDescriptor<TaskManagerConfig> = {
schema: configSchema,
exposeToUsage: {
max_workers: true,
},
deprecations: () => [
(settings, fromPath, addDeprecation) => {
const taskManager = get(settings, fromPath);