maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Data Table] Formatting CSV properly (#54127) (#54565)

Browse source 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Maja Grubic 2020-01-13 13:03:44 +00:00 committed by GitHub
parent 71a6fa5435
commit 19ddf27275
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/legacy/core_plugins/vis_type_table/public/agg_table/agg_table.js
View file

@ -74,7 +74,11 @@ export function KbnAggTable(config, RecursionHelper) {
// escape each cell in each row
const csvRows = rows.map(function(row) {
return Object.entries(row).map(([k, v]) => {
return escape(formatted ? columns.find(c => c.id === k).formatter.convert(v) : v);
const column = columns.find(c => c.id === k);
if (formatted && column) {
return escape(column.formatter.convert(v));
}
return escape(v);
});
});
@ -110,12 +114,16 @@ export function KbnAggTable(config, RecursionHelper) {
if (typeof $scope.dimensions === 'undefined') return;
const { buckets, metrics } = $scope.dimensions;
const { buckets, metrics, splitColumn } = $scope.dimensions;
$scope.formattedColumns = table.columns
.map(function(col, i) {
const isBucket = buckets.find(bucket => bucket.accessor === i);
const dimension = isBucket || metrics.find(metric => metric.accessor === i);
const isSplitColumn = splitColumn
? splitColumn.find(splitColumn => splitColumn.accessor === i)
: undefined;
const dimension =
isBucket || isSplitColumn || metrics.find(metric => metric.accessor === i);
if (!dimension) return;