maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix scrolling list on Firefox (#26246) (#26532)

Browse source 
* Fix scrolling list on Firefox

* Update jest snapshost after adding a class to modal
This commit is contained in:
Marco Vettorello 2018-12-03 23:31:19 +01:00 committed by GitHub
parent da04022f19
commit 1d1296a483
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/legacy/core_plugins/kibana/public/visualize/wizard/__snapshots__/new_vis_modal.test.tsx.snap
View file

@ -366,6 +366,7 @@ exports[`NewVisModal should render as expected 1`] = `
>
<EuiFlexGroup
alignItems="stretch"
className="visNewVisDialog__list"
component="div"
direction="column"
gutterSize="none"
@ -374,7 +375,7 @@ exports[`NewVisModal should render as expected 1`] = `
wrap={false}
>
<div
className="euiFlexGroup euiFlexGroup--directionColumn"
className="euiFlexGroup euiFlexGroup--directionColumn visNewVisDialog__list"
>
<EuiFlexItem
className="visNewVisDialog__searchWrapper"

5
src/legacy/core_plugins/kibana/public/visualize/wizard/_dialog.scss
View file

@ -8,6 +8,10 @@
.visNewVisDialog__body {
display: flex;
padding: $euiSizeM $euiSizeL 0;
min-height: 0;
}
.visNewVisDialog__list {
min-height: 0;
}
.visNewVisDialog__searchWrapper {
@ -16,6 +20,7 @@
.visNewVisDialog__typesWrapper {
max-width: $euiSizeXXL * 10;
min-height: 0;
padding-top: 2px; // Account for search field dropshadow
padding-bottom: $euiSize;
// Add overflow shadows via pseudo elements

7
src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/type_selection.tsx
View file

@ -79,7 +79,12 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
<div className="visNewVisDialog__body">
<EuiFlexGroup gutterSize="xl">
<EuiFlexItem>
<EuiFlexGroup direction="column" gutterSize="none" responsive={false}>
<EuiFlexGroup
className="visNewVisDialog__list"
direction="column"
gutterSize="none"
responsive={false}
>
<EuiFlexItem grow={false} className="visNewVisDialog__searchWrapper">
<EuiFieldSearch
placeholder="Filter"