maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Security Solution][Detections] Fix flaky threshold API tests (#97768)

Browse source 
* Explicitly refreshes signals index for threshold api tests to prevent flakiness

* Unskip test suite
This commit is contained in:
Marshall Main 2021-04-21 16:13:15 -04:00 committed by GitHub
parent 688bb6d3e2
commit 1fb00900e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts
View file

@ -20,6 +20,7 @@ import {
createSignalsIndex,
deleteAllAlerts,
deleteSignalsIndex,
getOpenSignals,
getRuleForSignalTesting,
getSignalsByIds,
getSignalsByRuleIds,
@ -39,9 +40,9 @@ export const ID = 'BhbXBmkBR346wHgn4PeZ';
export default ({ getService }: FtrProviderContext) => {
const supertest = getService('supertest');
const esArchiver = getService('esArchiver');
const es = getService('es');
// FLAKY: https://github.com/elastic/kibana/issues/97584
describe.skip('Generating signals from source indexes', () => {
describe('Generating signals from source indexes', () => {
beforeEach(async () => {
await createSignalsIndex(supertest);
});
@ -728,9 +729,8 @@ export default ({ getService }: FtrProviderContext) => {
],
},
};
const { id } = await createRule(supertest, rule);
await waitForRuleSuccessOrStatus(supertest, id);
const signalsOpen = await getSignalsByRuleIds(supertest, [ruleId]);
const createdRule = await createRule(supertest, rule);
const signalsOpen = await getOpenSignals(supertest, es, createdRule);
expect(signalsOpen.hits.hits.length).eql(0);
});
@ -753,9 +753,8 @@ export default ({ getService }: FtrProviderContext) => {
],
},
};
const { id } = await createRule(supertest, rule);
await waitForRuleSuccessOrStatus(supertest, id);
const signalsOpen = await getSignalsByRuleIds(supertest, [ruleId]);
const createdRule = await createRule(supertest, rule);
const signalsOpen = await getOpenSignals(supertest, es, createdRule);
expect(signalsOpen.hits.hits.length).eql(0);
});
@ -778,9 +777,8 @@ export default ({ getService }: FtrProviderContext) => {
],
},
};
const { id } = await createRule(supertest, rule);
await waitForRuleSuccessOrStatus(supertest, id);
const signalsOpen = await getSignalsByRuleIds(supertest, [ruleId]);
const createdRule = await createRule(supertest, rule);
const signalsOpen = await getOpenSignals(supertest, es, createdRule);
expect(signalsOpen.hits.hits.length).eql(1);
const signal = signalsOpen.hits.hits[0];
expect(signal._source.signal.threshold_result).eql({
@ -814,9 +812,8 @@ export default ({ getService }: FtrProviderContext) => {
value: 22,
},
};
const { id } = await createRule(supertest, rule);
await waitForRuleSuccessOrStatus(supertest, id);
const signalsOpen = await getSignalsByRuleIds(supertest, [ruleId]);
const createdRule = await createRule(supertest, rule);
const signalsOpen = await getOpenSignals(supertest, es, createdRule);
expect(signalsOpen.hits.hits.length).eql(0);
});
@ -833,9 +830,8 @@ export default ({ getService }: FtrProviderContext) => {
value: 21,
},
};
const { id } = await createRule(supertest, rule);
await waitForRuleSuccessOrStatus(supertest, id);
const signalsOpen = await getSignalsByRuleIds(supertest, [ruleId]);
const createdRule = await createRule(supertest, rule);
const signalsOpen = await getOpenSignals(supertest, es, createdRule);
expect(signalsOpen.hits.hits.length).eql(1);
const signal = signalsOpen.hits.hits[0];
expect(signal._source.signal.threshold_result).eql({