maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Lens] Fix value popover spacing (#103081)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Marco Liberati 2021-06-30 10:06:38 +02:00 committed by GitHub
parent 790bd35ea7
commit 21858a570d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
x-pack/plugins/lens/public/xy_visualization/visual_options_popover/line_curve_option.tsx
View file

@ -7,7 +7,7 @@
import React from 'react';
import { i18n } from '@kbn/i18n';
import { EuiFormRow, EuiSpacer, EuiSwitch } from '@elastic/eui';
import { EuiFormRow, EuiSwitch } from '@elastic/eui';
import { XYCurveType } from '../types';
export interface LineCurveOptionProps {
@ -28,29 +28,26 @@ export const LineCurveOption: React.FC<LineCurveOptionProps> = ({
isCurveTypeEnabled = true,
}) => {
return isCurveTypeEnabled ? (
<>
<EuiFormRow
display="columnCompressedSwitch"
label={i18n.translate('xpack.lens.xyChart.curveStyleLabel', {
defaultMessage: 'Curve lines',
})}
>
<EuiSwitch
showLabel={false}
label="Curved"
checked={value === 'CURVE_MONOTONE_X'}
compressed={true}
onChange={(e) => {
if (e.target.checked) {
onChange('CURVE_MONOTONE_X');
} else {
onChange('LINEAR');
}
}}
data-test-subj="lnsCurveStyleToggle"
/>
</EuiFormRow>
<EuiSpacer />
</>
<EuiFormRow
display="columnCompressedSwitch"
label={i18n.translate('xpack.lens.xyChart.curveStyleLabel', {
defaultMessage: 'Curve lines',
})}
>
<EuiSwitch
showLabel={false}
label="Curved"
checked={value === 'CURVE_MONOTONE_X'}
compressed={true}
onChange={(e) => {
if (e.target.checked) {
onChange('CURVE_MONOTONE_X');
} else {
onChange('LINEAR');
}
}}
data-test-subj="lnsCurveStyleToggle"
/>
</EuiFormRow>
) : null;
};

10
x-pack/plugins/lens/public/xy_visualization/visual_options_popover/missing_values_option.tsx
View file

@ -7,14 +7,7 @@
import React from 'react';
import { i18n } from '@kbn/i18n';
import {
EuiButtonGroup,
EuiFormRow,
EuiIconTip,
EuiSuperSelect,
EuiText,
EuiSpacer,
} from '@elastic/eui';
import { EuiButtonGroup, EuiFormRow, EuiIconTip, EuiSuperSelect, EuiText } from '@elastic/eui';
import { FittingFunction, fittingFunctionDefinitions } from '../fitting_functions';
import { ValueLabelConfig } from '../types';
@ -140,7 +133,6 @@ export const MissingValuesOptions: React.FC<MissingValuesOptionProps> = ({
/>
</EuiFormRow>
)}
<EuiSpacer />
</>
);
};