diff --git a/packages/eslint-config-kibana/.eslintrc.js b/packages/eslint-config-kibana/.eslintrc.js index 3308e613bfa3..146f3df763dd 100644 --- a/packages/eslint-config-kibana/.eslintrc.js +++ b/packages/eslint-config-kibana/.eslintrc.js @@ -172,6 +172,7 @@ module.exports = { 'import/no-named-as-default': 'error', 'import/no-named-as-default-member': 'error', 'import/no-duplicates': 'error', + 'import/no-dynamic-require': 'error', 'prefer-object-spread/prefer-object-spread': 'error', } diff --git a/packages/kbn-eslint-import-resolver-kibana/lib/get_plugins.js b/packages/kbn-eslint-import-resolver-kibana/lib/get_plugins.js index d9bcfc505486..319b959883a8 100755 --- a/packages/kbn-eslint-import-resolver-kibana/lib/get_plugins.js +++ b/packages/kbn-eslint-import-resolver-kibana/lib/get_plugins.js @@ -55,7 +55,7 @@ exports.getPlugins = function(config, kibanaPath, projectRoot) { return pluginsFromMap.concat( glob.sync(globPatterns).map(pkgJsonPath => { const path = dirname(pkgJsonPath); - const pkg = require(pkgJsonPath); + const pkg = require(pkgJsonPath); // eslint-disable-line import/no-dynamic-require return { name: pkg.name, directory: path, diff --git a/packages/kbn-interpreter/src/server/server_registries.js b/packages/kbn-interpreter/src/server/server_registries.js index 3a732f0d04e2..90dba7b82cff 100644 --- a/packages/kbn-interpreter/src/server/server_registries.js +++ b/packages/kbn-interpreter/src/server/server_registries.js @@ -57,7 +57,7 @@ export const populateServerRegistries = types => { global.canvas.register = d => registries[type].register(d); paths.forEach(path => { - require(path); + require(path); // eslint-disable-line import/no-dynamic-require }); Object.keys(global).forEach(key => { diff --git a/packages/kbn-plugin-generator/sao_template/sao.js b/packages/kbn-plugin-generator/sao_template/sao.js index d596409a3f62..df0090f2bf4f 100755 --- a/packages/kbn-plugin-generator/sao_template/sao.js +++ b/packages/kbn-plugin-generator/sao_template/sao.js @@ -27,7 +27,7 @@ const chalk = require('chalk'); const pkg = require('../package.json'); const kibanaPkgPath = require.resolve('../../../package.json'); -const kibanaPkg = require(kibanaPkgPath); +const kibanaPkg = require(kibanaPkgPath); // eslint-disable-line import/no-dynamic-require const KBN_DIR = dirname(kibanaPkgPath); diff --git a/packages/kbn-plugin-helpers/lib/utils.js b/packages/kbn-plugin-helpers/lib/utils.js index 078a7cd18633..ee82b9a8fd57 100644 --- a/packages/kbn-plugin-helpers/lib/utils.js +++ b/packages/kbn-plugin-helpers/lib/utils.js @@ -26,10 +26,10 @@ function babelRegister() { try { // add support for moved babel-register source: https://github.com/elastic/kibana/pull/13973 - require(resolve(plugin.kibanaRoot, 'src/setup_node_env/babel_register')); + require(resolve(plugin.kibanaRoot, 'src/setup_node_env/babel_register')); // eslint-disable-line import/no-dynamic-require } catch (error) { if (error.code === 'MODULE_NOT_FOUND') { - require(resolve(plugin.kibanaRoot, 'src/optimize/babel/register')); + require(resolve(plugin.kibanaRoot, 'src/optimize/babel/register')); // eslint-disable-line import/no-dynamic-require } else { throw error; } @@ -42,11 +42,8 @@ function resolveKibanaPath(path) { } function readFtrConfigFile(log, path, settingOverrides) { - return require(resolveKibanaPath('src/functional_test_runner')).readConfigFile( - log, - path, - settingOverrides - ); + return require(resolveKibanaPath('src/functional_test_runner')) // eslint-disable-line import/no-dynamic-require + .readConfigFile(log, path, settingOverrides); } module.exports = { diff --git a/packages/kbn-plugin-helpers/tasks/build/create_build.js b/packages/kbn-plugin-helpers/tasks/build/create_build.js index c8dfacb88a02..250d44b5a9a6 100644 --- a/packages/kbn-plugin-helpers/tasks/build/create_build.js +++ b/packages/kbn-plugin-helpers/tasks/build/create_build.js @@ -51,7 +51,7 @@ function removeSymlinkDependencies(root) { // parse a ts config file function parseTsconfig(pluginSourcePath, configPath) { - const ts = require(path.join(pluginSourcePath, 'node_modules', 'typescript')); + const ts = require(path.join(pluginSourcePath, 'node_modules', 'typescript')); // eslint-disable-line import/no-dynamic-require const { error, config } = ts.parseConfigFileTextToJson( configPath, diff --git a/packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js b/packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js index 12aba777361a..42ad1c5ae0cf 100644 --- a/packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js +++ b/packages/kbn-plugin-helpers/tasks/build/integration_tests/create_build.test.js @@ -42,7 +42,7 @@ describe('creating the build', () => { await createBuild(PLUGIN, buildTarget, buildVersion, kibanaVersion, buildFiles); - const pkg = require(resolve(PLUGIN_BUILD_TARGET, 'package.json')); + const pkg = require(resolve(PLUGIN_BUILD_TARGET, 'package.json')); // eslint-disable-line import/no-dynamic-require expect(pkg).not.toHaveProperty('scripts'); expect(pkg).not.toHaveProperty('devDependencies'); }); @@ -52,7 +52,7 @@ describe('creating the build', () => { await createBuild(PLUGIN, buildTarget, buildVersion, kibanaVersion, buildFiles); - const pkg = require(resolve(PLUGIN_BUILD_TARGET, 'package.json')); + const pkg = require(resolve(PLUGIN_BUILD_TARGET, 'package.json')); // eslint-disable-line import/no-dynamic-require expect(pkg).toHaveProperty('build'); expect(pkg.build.git).not.toBeUndefined(); expect(pkg.build.date).not.toBeUndefined(); diff --git a/src/dev/build/lib/config.js b/src/dev/build/lib/config.js index ce6715302590..9004715f0108 100644 --- a/src/dev/build/lib/config.js +++ b/src/dev/build/lib/config.js @@ -25,7 +25,7 @@ import { createPlatform } from './platform'; export async function getConfig({ isRelease, targetAllPlatforms, versionQualifier }) { const pkgPath = resolve(__dirname, '../../../../package.json'); - const pkg = require(pkgPath); + const pkg = require(pkgPath); // eslint-disable-line import/no-dynamic-require const repoRoot = dirname(pkgPath); const nodeVersion = pkg.engines.node; diff --git a/src/functional_test_runner/lib/config/read_config_file.js b/src/functional_test_runner/lib/config/read_config_file.js index e733d2b989ff..ce118020ea2d 100644 --- a/src/functional_test_runner/lib/config/read_config_file.js +++ b/src/functional_test_runner/lib/config/read_config_file.js @@ -25,7 +25,7 @@ import { transformDeprecations } from './transform_deprecations'; const cache = new WeakMap(); async function getSettingsFromFile(log, path, settingOverrides) { - const configModule = require(path); + const configModule = require(path); // eslint-disable-line import/no-dynamic-require const configProvider = configModule.__esModule ? configModule.default : configModule; diff --git a/src/functional_test_runner/lib/mocha/load_test_files.js b/src/functional_test_runner/lib/mocha/load_test_files.js index 96321be3dd82..c876c39b9c64 100644 --- a/src/functional_test_runner/lib/mocha/load_test_files.js +++ b/src/functional_test_runner/lib/mocha/load_test_files.js @@ -48,7 +48,7 @@ export const loadTestFiles = ({ mocha, log, lifecycle, providers, paths, exclude loadTracer(path, `testFile[${path}]`, () => { log.verbose('Loading test file %s', path); - const testModule = require(path); + const testModule = require(path); // eslint-disable-line import/no-dynamic-require const testProvider = testModule.__esModule ? testModule.default : testModule; diff --git a/src/legacy/core_plugins/console/api_server/server.js b/src/legacy/core_plugins/console/api_server/server.js index b9a42a457b90..57a53d20695a 100644 --- a/src/legacy/core_plugins/console/api_server/server.js +++ b/src/legacy/core_plugins/console/api_server/server.js @@ -27,7 +27,7 @@ export function resolveApi(senseVersion, apis, h) { { if (KNOWN_APIS.includes(name)) { // for now we ignore sense_version. might add it in the api name later - const api = require('./' + name); + const api = require('./' + name); // eslint-disable-line import/no-dynamic-require result[name] = api.asJson(); } } diff --git a/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/average.js b/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/average.js index 1cdfb6fab8b3..d54574d2cf4b 100644 --- a/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/average.js +++ b/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/average.js @@ -17,13 +17,12 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../average`); import moment from 'moment'; const expect = require('chai').expect; import _ from 'lodash'; -describe(filename, function () { +describe('average.js', function () { describe('average', function () { it('fills holes in the data', function () { diff --git a/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/carry.js b/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/carry.js index 0ed7fd1760b2..972f220111ed 100644 --- a/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/carry.js +++ b/src/legacy/core_plugins/timelion/server/fit_functions/__tests__/carry.js @@ -17,13 +17,12 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../carry`); import moment from 'moment'; const expect = require('chai').expect; import _ from 'lodash'; -describe(filename, function () { +describe('carry.js', function () { it('fills holes in the data', function () { const data = [ [moment.utc('1980', 'YYYY').valueOf(), 10], diff --git a/src/legacy/core_plugins/timelion/server/lib/__tests__/load_functions.js b/src/legacy/core_plugins/timelion/server/lib/__tests__/load_functions.js index 70cc8b44c781..45dd436be694 100644 --- a/src/legacy/core_plugins/timelion/server/lib/__tests__/load_functions.js +++ b/src/legacy/core_plugins/timelion/server/lib/__tests__/load_functions.js @@ -17,12 +17,11 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../load_functions`); const expect = require('chai').expect; -describe(filename, () => { +describe('load_functions.js', () => { it('exports a function', () => { expect(fn).to.be.a('function'); }); diff --git a/src/legacy/core_plugins/timelion/server/lib/load_functions.js b/src/legacy/core_plugins/timelion/server/lib/load_functions.js index 8587c107af82..b1c9c986d14a 100644 --- a/src/legacy/core_plugins/timelion/server/lib/load_functions.js +++ b/src/legacy/core_plugins/timelion/server/lib/load_functions.js @@ -25,7 +25,7 @@ import processFunctionDefinition from './process_function_definition'; export default function (directory) { function getTuple(directory, name) { - return [name, require('../' + directory + '/' + name)]; + return [name, require('../' + directory + '/' + name)]; // eslint-disable-line import/no-dynamic-require } // Get a list of all files and use the filename as the object key diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/abs.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/abs.js index 9af34f0ec35a..9d90a55bcb71 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/abs.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/abs.js @@ -17,15 +17,14 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../abs`); import _ from 'lodash'; const expect = require('chai').expect; const seriesList = require('./fixtures/seriesList.js')(); import invoke from './helpers/invoke_series_fn.js'; -describe(filename, function () { +describe('abs.js', function () { it('should return the positive value of every value', function () { return invoke(fn, [seriesList]).then(function (result) { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/bars.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/bars.js index 508ce02954f2..e64e5f8b87dd 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/bars.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/bars.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../bars`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('bars.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/color.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/color.js index 28a119752c2e..57c570f00471 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/color.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/color.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../color`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('color.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/condition.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/condition.js index 80b550f9cfb2..67bfa0cfdea9 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/condition.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/condition.js @@ -17,15 +17,14 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../condition`); import moment from 'moment'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; import getSeriesList from './helpers/get_single_series_list'; import _ from 'lodash'; -describe(filename, function () { +describe('condition.js', function () { let comparable; let seriesList; diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/cusum.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/cusum.js index 4417eafc8d74..dc0e88177f0c 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/cusum.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/cusum.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../cusum`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('cusum.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/derivative.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/derivative.js index c36296db2a38..dd0c134ff4b3 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/derivative.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/derivative.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../derivative`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('derivative.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/divide.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/divide.js index 10ce51e17cd2..bee664c7a483 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/divide.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/divide.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../divide`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('divide.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/first.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/first.js index aa81fc38b646..73d729631c03 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/first.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/first.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../first`); const expect = require('chai').expect; const seriesList = require('./fixtures/seriesList.js')(); import invoke from './helpers/invoke_series_fn.js'; -describe(filename, function () { +describe('first.js', function () { it('should return exactly the data input', function () { return invoke(fn, [seriesList]).then(function (result) { expect(result.input[0]).to.eql(result.output); diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/fit.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/fit.js index 2bd42f5815cb..adb3a3a7b11a 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/fit.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/fit.js @@ -17,15 +17,14 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../fit`); import moment from 'moment'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; import getSeriesList from './helpers/get_single_series_list'; import _ from 'lodash'; -describe(filename, function () { +describe('fit.js', function () { describe('should not filter out zeros', function () { it('all zeros', function () { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/hide.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/hide.js index 8ff4f34466ef..ed7df1fd5f21 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/hide.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/hide.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../hide`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('hide.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/label.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/label.js index f581cf40c422..c89aa1d5197c 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/label.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/label.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../label`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('label.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/legend.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/legend.js index 0fa5632f21fd..f85b2cefffd7 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/legend.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/legend.js @@ -17,13 +17,12 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../legend`); const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('legend.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/lines.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/lines.js index daa03d3c48d8..83cd066b6c7e 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/lines.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/lines.js @@ -17,13 +17,12 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../lines`); const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('lines.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/log.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/log.js index e3e5b364ce02..41ccb5671649 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/log.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/log.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../log`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('log.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/max.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/max.js index 087e6e6735cf..a5ed446cdba5 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/max.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/max.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../max`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('max.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/min.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/min.js index 0591518eaf24..e3f29805787e 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/min.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/min.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../min`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('min.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingaverage.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingaverage.js index 4d974eaa6ca6..a502e23b9cdd 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingaverage.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingaverage.js @@ -17,8 +17,7 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../movingaverage`); const expect = require('chai').expect; import moment from 'moment'; @@ -34,7 +33,7 @@ function getFivePointSeries() { ]); } -describe(filename, () => { +describe('movingaverage.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingstd.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingstd.js index 64d4ba63c5d3..e7470ecd0888 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingstd.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/movingstd.js @@ -17,8 +17,7 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../movingstd`); import moment from 'moment'; const expect = require('chai').expect; @@ -26,7 +25,7 @@ import invoke from './helpers/invoke_series_fn.js'; import getSeries from './helpers/get_series'; import getSeriesList from './helpers/get_series_list'; -describe(filename, () => { +describe('movingstd.js', () => { it('computes the moving standard deviation of a list', async () => { const points = [ diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/multiply.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/multiply.js index 30ab1b9531ea..025ed81da1cf 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/multiply.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/multiply.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../multiply`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('multiply.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/points.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/points.js index 811ab4d4f067..1ab86348620d 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/points.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/points.js @@ -17,15 +17,14 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../points`); import _ from 'lodash'; import assert from 'chai'; const expect = assert.expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('points.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/precision.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/precision.js index 97ae42f6cac8..68de2eb04a09 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/precision.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/precision.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../precision`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('precision.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/range.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/range.js index 9d29e9b0f61f..e98d8a527e69 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/range.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/range.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../range`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('range.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/scale_interval.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/scale_interval.js index 692319b6f622..b9c92c164170 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/scale_interval.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/scale_interval.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../scale_interval`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('scale_interval.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/static.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/static.js index 239892ddad4a..4e5500d55a4a 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/static.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/static.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../static`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('static.js', () => { it('returns a series in which all numbers are the same', () => { return invoke(fn, [5]).then((r) => { expect(_.unique(_.map(r.output.list[0].data, 1))).to.eql([5]); diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/subtract.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/subtract.js index 2c81ed92e79c..f34c46e7834f 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/subtract.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/subtract.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../subtract`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('subtract.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/sum.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/sum.js index 553a4ec9f39c..488301132ccf 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/sum.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/sum.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../sum`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('sum.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/title.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/title.js index 3715043b4059..5fac9f8a2783 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/title.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/title.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../title`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('title.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/trim.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/trim.js index 43b6500e9965..183e22fc49a0 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/trim.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/trim.js @@ -17,14 +17,13 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../trim`); import _ from 'lodash'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('trim.js', () => { let seriesList; beforeEach(() => { diff --git a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/yaxis.js b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/yaxis.js index cecafea98337..7a181d9cbb8c 100644 --- a/src/legacy/core_plugins/timelion/server/series_functions/__tests__/yaxis.js +++ b/src/legacy/core_plugins/timelion/server/series_functions/__tests__/yaxis.js @@ -17,13 +17,12 @@ * under the License. */ -const filename = require('path').basename(__filename); -const fn = require(`../${filename}`); +const fn = require(`../yaxis`); import Promise from 'bluebird'; const expect = require('chai').expect; import invoke from './helpers/invoke_series_fn.js'; -describe(filename, () => { +describe('yaxis.js', () => { let seriesList; beforeEach(() => { seriesList = require('./fixtures/seriesList.js')(); diff --git a/src/plugin_discovery/plugin_pack/create_pack.js b/src/plugin_discovery/plugin_pack/create_pack.js index 39780ec7a421..21d3478d08e1 100644 --- a/src/plugin_discovery/plugin_pack/create_pack.js +++ b/src/plugin_discovery/plugin_pack/create_pack.js @@ -22,7 +22,7 @@ import { map, catchError } from 'rxjs/operators'; import { createInvalidPackError } from '../errors'; function createPack(packageJson) { - let provider = require(packageJson.directoryPath); + let provider = require(packageJson.directoryPath); // eslint-disable-line import/no-dynamic-require if (provider.__esModule) { provider = provider.default; } diff --git a/src/server/http/integration_tests/version_check.test.js b/src/server/http/integration_tests/version_check.test.js index 3b3d70e5f35a..ce34bb9bb61c 100644 --- a/src/server/http/integration_tests/version_check.test.js +++ b/src/server/http/integration_tests/version_check.test.js @@ -23,7 +23,7 @@ import * as kbnTestServer from '../../../test_utils/kbn_server'; const src = resolve.bind(null, __dirname, '../../../../src'); const versionHeader = 'kbn-version'; -const version = require(src('../package.json')).version; +const version = require(src('../package.json')).version; // eslint-disable-line import/no-dynamic-require describe('version_check request filter', function () { let root; diff --git a/src/server/http/integration_tests/xsrf.test.js b/src/server/http/integration_tests/xsrf.test.js index 61c38e2878c3..7a54f04a8b60 100644 --- a/src/server/http/integration_tests/xsrf.test.js +++ b/src/server/http/integration_tests/xsrf.test.js @@ -27,7 +27,7 @@ const xsrfHeader = 'kbn-xsrf'; const versionHeader = 'kbn-version'; const testPath = '/xsrf/test/route'; const whitelistedTestPath = '/xsrf/test/route/whitelisted'; -const actualVersion = require(src('../package.json')).version; +const actualVersion = require(src('../package.json')).version; // eslint-disable-line import/no-dynamic-require describe('xsrf request filter', () => { let root; diff --git a/x-pack/dev-tools/api_debug/index.js b/x-pack/dev-tools/api_debug/index.js index 73569892d1a8..cdec01732b3e 100644 --- a/x-pack/dev-tools/api_debug/index.js +++ b/x-pack/dev-tools/api_debug/index.js @@ -20,7 +20,7 @@ async function listFiles() { const pattern = resolve(__dirname, './apis/*/index.js'); const files = await scan(pattern); files.forEach(file => { - const { name, description } = require(file); + const { name, description } = require(file); // eslint-disable-line import/no-dynamic-require console.log(' ' + bold(`node ${argv.$0} ${name}`)); console.log(` ${description}`); }); diff --git a/x-pack/dev-tools/api_debug/request_from_api.js b/x-pack/dev-tools/api_debug/request_from_api.js index 93726fa8d6cb..072f85644c52 100644 --- a/x-pack/dev-tools/api_debug/request_from_api.js +++ b/x-pack/dev-tools/api_debug/request_from_api.js @@ -56,7 +56,7 @@ function prettyPrintJson(json) { export async function requestFromApi(argv, requestType) { const pattern = resolve(__dirname, `./apis/${requestType}/index.js`); - const { method, path, body } = require(pattern); + const { method, path, body } = require(pattern); // eslint-disable-line import/no-dynamic-require const { host, auth, basePath } = getRequestParams(argv); if (argv.k || !argv.ssl) { setIgnoreSSLErrors(); diff --git a/x-pack/plugins/canvas/scripts/_helpers.js b/x-pack/plugins/canvas/scripts/_helpers.js index 222b38c7eb4e..687faad14e0a 100644 --- a/x-pack/plugins/canvas/scripts/_helpers.js +++ b/x-pack/plugins/canvas/scripts/_helpers.js @@ -15,5 +15,5 @@ exports.runGulpTask = function(name) { exports.runKibanaScript = function(name, args = []) { process.chdir(resolve(__dirname, '../../../..')); process.argv.splice(2, 0, ...args); - require('../../../../scripts/' + name); + require('../../../../scripts/' + name); // eslint-disable-line import/no-dynamic-require }; diff --git a/x-pack/plugins/reporting/server/lib/export_types_registry.js b/x-pack/plugins/reporting/server/lib/export_types_registry.js index d7b66b84ace7..7631161c4f89 100644 --- a/x-pack/plugins/reporting/server/lib/export_types_registry.js +++ b/x-pack/plugins/reporting/server/lib/export_types_registry.js @@ -28,7 +28,7 @@ async function exportTypesRegistryFn(server) { files.forEach(file => { server.log(['reporting', 'debug', 'exportTypes'], `Found exportType at ${file}`); - const { register } = require(file); + const { register } = require(file); // eslint-disable-line import/no-dynamic-require register(exportTypesRegistry); }); return exportTypesRegistry;