From 24b0177688d78aedcec2bd4f03464b42468b6629 Mon Sep 17 00:00:00 2001 From: LeeDr Date: Tue, 19 Jan 2016 12:41:17 -0600 Subject: [PATCH] Fix screenshots Data Table and Tile Map. Add comments. --- test/functional/apps/visualize/_area_chart.js | 3 +++ test/functional/apps/visualize/_line_chart.js | 1 + test/functional/apps/visualize/_pie_chart.js | 1 + test/functional/apps/visualize/_tile_map.js | 1 + 4 files changed, 6 insertions(+) diff --git a/test/functional/apps/visualize/_area_chart.js b/test/functional/apps/visualize/_area_chart.js index e07bed2e54e5..8251cec57d8c 100644 --- a/test/functional/apps/visualize/_area_chart.js +++ b/test/functional/apps/visualize/_area_chart.js @@ -115,6 +115,9 @@ define(function (require) { .then(function () { return visualizePage.waitForVisualization(); }) + // We have to sleep sometime between loading the saved visTitle + // and trying to access the chart below with getXAxisLabels + // otherwise it hangs. .then(function sleep() { return common.sleep(2000); }) diff --git a/test/functional/apps/visualize/_line_chart.js b/test/functional/apps/visualize/_line_chart.js index 9b7f6c0c53c3..a6c817d20e8c 100644 --- a/test/functional/apps/visualize/_line_chart.js +++ b/test/functional/apps/visualize/_line_chart.js @@ -119,6 +119,7 @@ define(function (require) { // it could also check the legend to verify the extensions var expectedChartData = ['jpg 9,109', 'css 2,159', 'png 1,373', 'gif 918', 'php 445']; + // sleep a bit before trying to get the chart data return common.sleep(3000) .then(function () { return visualizePage.getLineChartData() diff --git a/test/functional/apps/visualize/_pie_chart.js b/test/functional/apps/visualize/_pie_chart.js index 68d41aeca283..6ff909606947 100644 --- a/test/functional/apps/visualize/_pie_chart.js +++ b/test/functional/apps/visualize/_pie_chart.js @@ -114,6 +114,7 @@ define(function (require) { .then(function waitForVisualization() { return visualizePage.waitForVisualization(); }) + // sleep a bit before trying to get the pie chart data below .then(function sleep() { return common.sleep(2000); }) diff --git a/test/functional/apps/visualize/_tile_map.js b/test/functional/apps/visualize/_tile_map.js index 7110646de0a0..75044876c2ac 100644 --- a/test/functional/apps/visualize/_tile_map.js +++ b/test/functional/apps/visualize/_tile_map.js @@ -107,6 +107,7 @@ define(function (require) { .then(function waitForVisualization() { return visualizePage.waitForVisualization(); }) + // sleep a bit before taking the screenshot or it won't show data .then(function sleep() { return common.sleep(4000); })