maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Fixes sort on Calendars list events column so that it is done numerically (#27517)

Browse source 
* Ensure calendar list events col sorted numerically

* update corresponding tests
This commit is contained in:
Melissa Alvarez 2018-12-19 11:12:05 -07:00 committed by GitHub
parent 2759e3505c
commit 24cb299ba4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/ml/public/settings/calendars/list/__snapshots__/calendars_list.test.js.snap
View file

@ -26,7 +26,7 @@ exports[`CalendarsList Renders calendar list with calendars 1`] = `
"start_time": 1486656600000,
},
],
"events_length": "1 event",
"events_length": 1,
"job_ids": Array [
"farequote",
],
@ -44,7 +44,7 @@ exports[`CalendarsList Renders calendar list with calendars 1`] = `
"start_time": 1544076000000,
},
],
"events_length": "1 event",
"events_length": 1,
"job_ids": Array [
"test",
],

3
x-pack/plugins/ml/public/settings/calendars/list/calendars_list.js
View file

@ -75,9 +75,8 @@ export class CalendarsList extends Component {
addRequiredFieldsToList = (calendarsList = []) => {
for (let i = 0; i < calendarsList.length; i++) {
const eventLength = calendarsList[i].events.length;
calendarsList[i].job_ids_string = calendarsList[i].job_ids.join(', ');
calendarsList[i].events_length = `${eventLength} ${eventLength === 1 ? 'event' : 'events'}`;
calendarsList[i].events_length = calendarsList[i].events.length;
}
return calendarsList;

1
x-pack/plugins/ml/public/settings/calendars/list/table/__snapshots__/table.test.js.snap
View file

@ -21,6 +21,7 @@ exports[`CalendarsListTable renders the table with all calendars 1`] = `
Object {
"field": "events_length",
"name": "Events",
"render": [Function],
"sortable": true,
},
]

3
x-pack/plugins/ml/public/settings/calendars/list/table/table.js
View file

@ -64,7 +64,8 @@ export function CalendarsListTable({
{
field: 'events_length',
name: 'Events',
sortable: true
sortable: true,
render: (eventsLength) => `${eventsLength} ${eventsLength === 1 ? 'event' : 'events'}`
}
];