maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Lens] refactor to not filter layers three times (#66174)

Browse source
This commit is contained in:
Marta Bondyra 2020-05-12 17:46:35 +02:00 committed by GitHub
parent 9919dff004
commit 25a3fcea52
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
x-pack/plugins/lens/public/xy_visualization/xy_expression.tsx
View file

@ -236,17 +236,9 @@ export function XYChart({
// check all the tables to see if all of the rows have the same timestamp
// that would mean that chart will draw a single bar
const isSingleTimestampInXDomain = () => {
const nonEmptyLayers = layers.filter(
layer => data.tables[layer.layerId].rows.length && layer.xAccessor
);
if (!nonEmptyLayers.length) {
return;
}
const firstRowValue =
data.tables[nonEmptyLayers[0].layerId].rows[0][nonEmptyLayers[0].xAccessor!];
for (const layer of nonEmptyLayers) {
data.tables[filteredLayers[0].layerId].rows[0][filteredLayers[0].xAccessor!];
for (const layer of filteredLayers) {
if (
layer.xAccessor &&
data.tables[layer.layerId].rows.some(row => row[layer.xAccessor!] !== firstRowValue)
@ -270,7 +262,7 @@ export function XYChart({
return undefined;
}
const isTimeViz = data.dateRange && layers.every(l => l.xScaleType === 'time');
const isTimeViz = data.dateRange && filteredLayers.every(l => l.xScaleType === 'time');
const xDomain = isTimeViz
? {
@ -299,12 +291,10 @@ export function XYChart({
return;
}
const firstLayerWithData =
layers[layers.findIndex(layer => data.tables[layer.layerId].rows.length)];
const table = data.tables[firstLayerWithData.layerId];
const table = data.tables[filteredLayers[0].layerId];
const xAxisColumnIndex = table.columns.findIndex(
el => el.id === firstLayerWithData.xAccessor
el => el.id === filteredLayers[0].xAccessor
);
const timeFieldName = table.columns[xAxisColumnIndex]?.meta?.aggConfigParams?.field;