maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Removed one liner deprecation found with ElasticClient and made it harder to accidently import from the kbn package (#110318)

Browse source 
## Summary

Removes ElasticSearch deprecation and makes it harder to import it from the wrong package. I accidentally exposed a deprecated `ElasticSearch` from a package we do not want to expose and everyone's IDE is suggesting it rather than the correct one from Kibana core.

* Removes the type from the exports within the package
* Fixes the instance that is trying to import it in favor of the correct one.
This commit is contained in:
Frank Hassanabad 2021-08-26 15:24:16 -06:00 committed by GitHub
parent 18fe8c4987
commit 2859eeb7de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/kbn-securitysolution-es-utils/src/index.ts
View file

@ -12,7 +12,6 @@ export * from './decode_version';
export * from './delete_all_index';
export * from './delete_policy';
export * from './delete_template';
export * from './elasticsearch_client';
export * from './encode_hit_version';
export * from './get_index_aliases';
export * from './get_index_count';

7
x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts
View file

@ -17,14 +17,17 @@ import type { ListArray, ExceptionListItemSchema } from '@kbn/securitysolution-i
import { MAX_EXCEPTION_LIST_SIZE } from '@kbn/securitysolution-list-constants';
import { hasLargeValueList } from '@kbn/securitysolution-list-utils';
import { parseScheduleDates } from '@kbn/securitysolution-io-ts-utils';
import { ElasticsearchClient } from '@kbn/securitysolution-es-utils';
import {
TimestampOverrideOrUndefined,
Privilege,
RuleExecutionStatus,
} from '../../../../common/detection_engine/schemas/common/schemas';
import { Logger, SavedObjectsClientContract } from '../../../../../../../src/core/server';
import {
ElasticsearchClient,
Logger,
SavedObjectsClientContract,
} from '../../../../../../../src/core/server';
import {
AlertInstanceContext,
AlertInstanceState,