maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Uptime ]Update empty message for certs list (#78575)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Shahzad 2020-12-10 10:08:06 +01:00 committed by GitHub
parent 2038582358
commit 29235267c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 79 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx
View file

@ -14,6 +14,7 @@ import { CertMonitors } from './cert_monitors';
import * as labels from './translations';
import { Cert, CertMonitor } from '../../../common/runtime_types';
import { FingerprintCol } from './fingerprint_col';
import { NO_CERTS_AVAILABLE } from './translations';
interface Page {
index: number;
@ -109,6 +110,7 @@ export const CertificateList: React.FC<Props> = ({ page, sort, onChange }) => {
direction: sort.direction,
},
}}
noItemsMessage={<span data-test-subj="uptimeCertsEmptyMessage">{NO_CERTS_AVAILABLE}</span>}
/>
);
};

4
x-pack/plugins/uptime/public/components/certificates/translations.ts
View file

@ -65,3 +65,7 @@ export const FINGERPRINTS_COL = i18n.translate('xpack.uptime.certs.list.expirati
export const COPY_FINGERPRINT = i18n.translate('xpack.uptime.certs.list.copyFingerprint', {
defaultMessage: 'Click to copy fingerprint value',
});
export const NO_CERTS_AVAILABLE = i18n.translate('xpack.uptime.certs.list.empty', {
defaultMessage: 'No Certificates found. Note: Certificates are only visible for Heartbeat 7.8+',
});

114
x-pack/test/functional/apps/uptime/certificates.ts
View file

@ -15,63 +15,81 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const es = getService('es');
describe('certificates', function () {
before(async () => {
await makeCheck({ es, tls: true });
await uptime.goToRoot(true);
});
describe('empty certificates', function () {
before(async () => {
await makeCheck({ es });
await uptime.goToRoot(true);
});
beforeEach(async () => {
await makeCheck({ es, tls: true });
});
it('can navigate to cert page', async () => {
await uptimeService.common.waitUntilDataIsLoaded();
await uptimeService.cert.hasViewCertButton();
await uptimeService.navigation.goToCertificates();
});
describe('page', () => {
beforeEach(async () => {
it('go to certs page', async () => {
await uptimeService.common.waitUntilDataIsLoaded();
await uptimeService.cert.hasViewCertButton();
await uptimeService.navigation.goToCertificates();
await uptimeService.navigation.refreshApp();
});
it('displays empty message', async () => {
await uptimeService.cert.displaysEmptyMessage();
});
});
describe('with certs', function () {
before(async () => {
await makeCheck({ es, tls: true });
await uptime.goToRoot(true);
});
it('displays certificates', async () => {
await uptimeService.cert.hasCertificates();
beforeEach(async () => {
await makeCheck({ es, tls: true });
});
it('displays specific certificates', async () => {
const certId = getSha256();
const { monitorId } = await makeCheck({
es,
tls: {
sha256: certId,
},
it('can navigate to cert page', async () => {
await uptimeService.common.waitUntilDataIsLoaded();
await uptimeService.cert.hasViewCertButton();
await uptimeService.navigation.goToCertificates();
});
describe('page', () => {
beforeEach(async () => {
await uptimeService.navigation.goToCertificates();
await uptimeService.navigation.refreshApp();
});
await uptimeService.navigation.refreshApp();
await uptimeService.cert.certificateExists({ certId, monitorId });
});
it('performs search against monitor id', async () => {
const certId = getSha256();
const { monitorId } = await makeCheck({
es,
monitorId: 'cert-test-check-id',
fields: {
monitor: {
name: 'Cert Test Check',
},
url: {
full: 'https://site-to-check.com/',
},
},
tls: {
sha256: certId,
},
it('displays certificates', async () => {
await uptimeService.cert.hasCertificates();
});
it('displays specific certificates', async () => {
const certId = getSha256();
const { monitorId } = await makeCheck({
es,
tls: {
sha256: certId,
},
});
await uptimeService.navigation.refreshApp();
await uptimeService.cert.certificateExists({ certId, monitorId });
});
it('performs search against monitor id', async () => {
const certId = getSha256();
const { monitorId } = await makeCheck({
es,
monitorId: 'cert-test-check-id',
fields: {
monitor: {
name: 'Cert Test Check',
},
url: {
full: 'https://site-to-check.com/',
},
},
tls: {
sha256: certId,
},
});
await uptimeService.navigation.refreshApp();
await uptimeService.cert.searchIsWorking(monitorId);
});
await uptimeService.navigation.refreshApp();
await uptimeService.cert.searchIsWorking(monitorId);
});
});
});

7
x-pack/test/functional/services/uptime/certificates.ts
View file

@ -59,5 +59,12 @@ export function UptimeCertProvider({ getService, getPageObjects }: FtrProviderCo
await self.hasCertificates(1);
});
},
async displaysEmptyMessage() {
await testSubjects.existOrFail('uptimeCertsEmptyMessage');
const emptyText = await testSubjects.getVisibleText('uptimeCertsEmptyMessage');
expect(emptyText).to.eql(
'No Certificates found. Note: Certificates are only visible for Heartbeat 7.8+'
);
},
};
}