addressing reviewer comments

This commit is contained in:
Shelby Sturgis 2016-03-17 10:03:24 -07:00
parent c42d9c214f
commit 29fb459e11
3 changed files with 7 additions and 9 deletions

View file

@ -7,9 +7,7 @@ var module = uiModules.get('kibana');
module.directive('breadCrumbs', function () {
return {
restrict: 'E',
scope: {
userMakeUrl: '=?makeUrl'
},
scope: true,
template: breadCrumbsTemplate,
controller: function ($scope) {
$scope.crumbs = chrome.getBreadcrumbs();

View file

@ -1,6 +1,6 @@
<ul>
<li ng-repeat="crumb in crumbs">
<a ng-href="{{ makeUrl(crumb) }}">{{crumb}}</a>
<span ng-hide="$index === (crumbs.length - 1)"> / </span>
<span ng-hide="$last"> / </span>
</li>
</ul>

View file

@ -295,18 +295,18 @@ bread-crumbs {
list-style-type: none;
text-transform: capitalize;
&>li {
>li {
display: inline;
&>a {
>a {
color: @kibanaGray2;
}
&>a:hover {
>a:hover {
color: @kibanaGray1;
}
}
&>li:last-child {
&>a {
>li:last-child {
>a {
color: @kibanaGray1;
}
}