maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix issue with heatmap showing black tiles (#20753) (#22535)

Browse source 
* Heatmap metric data points should only be quantized while the data full range is grate than the maxmum allowed color count

* The data cell with metric value 'null' should always be hidden in the heatmap

* Add one variable for max color count and follow the coding style
This commit is contained in:
Marco Vettorello 2018-08-30 15:57:14 +02:00 committed by GitHub
parent df8b8304b5
commit 2a190be694
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/ui/public/vislib/visualizations/point_series/heatmap_chart.js
View file

@ -69,6 +69,7 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
const zScale = this.getValueAxis().getScale();
const [min, max] = zScale.domain();
const labels = [];
const maxColorCnt = 10;
if (cfg.get('setColorRange')) {
colorsRange.forEach(range => {
const from = isFinite(range.from) ? zAxisFormatter(range.from) : range.from;
@ -90,8 +91,14 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
} else {
val = val * (max - min) + min;
nextVal = nextVal * (max - min) + min;
if (max > 1) {
val = Math.ceil(val);
if (max - min > maxColorCnt) {
const valInt = Math.ceil(val);
if (i === 0) {
val = (valInt === val ? val : valInt - 1);
}
else{
val = valInt;
}
nextVal = Math.ceil(nextVal);
}
if (isFinite(val)) val = zAxisFormatter(val);
@ -184,12 +191,16 @@ export function VislibVisualizationsHeatmapChartProvider(Private) {
val = Math.min(colorsNumber - 1, Math.floor(val * colorsNumber));
}
}
if (d.y == null) {
return -1;
}
return !isNaN(val) ? val : -1;
}
function label(d) {
const colorBucket = getColorBucket(d);
if (colorBucket === -1) d.hide = true;
// colorBucket id should always GTE 0
if (colorBucket < 0) d.hide = true;
return labels[colorBucket];
}