maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove last mentions of spy panels (#23527) (#23533)

Browse source
This commit is contained in:
Tim Roes 2018-09-26 19:08:12 +02:00 committed by GitHub
parent 67adddecb6
commit 2cb1f3e9db
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 3 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/setup/settings.asciidoc
View file

@ -22,7 +22,7 @@ you'll need to update your `kibana.yml` file. You can also enable SSL and set a
`elasticsearch.customHeaders:`:: *Default: `{}`* Header names and values to send to Elasticsearch. Any custom headers `elasticsearch.customHeaders:`:: *Default: `{}`* Header names and values to send to Elasticsearch. Any custom headers
cannot be overwritten by client-side headers, regardless of the `elasticsearch.requestHeadersWhitelist` configuration. cannot be overwritten by client-side headers, regardless of the `elasticsearch.requestHeadersWhitelist` configuration.
`elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have a spy panel, for example Timelion and Monitoring. `elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have an inspector, for example Timelion and Monitoring.
`elasticsearch.pingTimeout:`:: *Default: the value of the `elasticsearch.requestTimeout` setting* Time in milliseconds to `elasticsearch.pingTimeout:`:: *Default: the value of the `elasticsearch.requestTimeout` setting* Time in milliseconds to
wait for Elasticsearch to respond to pings. wait for Elasticsearch to respond to pings.

2
src/ui/public/inspector/types.ts
View file

@ -18,7 +18,7 @@
*/ */
/** /**
* The interface that the adapters used to open spy panels have to fullfill. * The interface that the adapters used to open an inspector have to fullfill.
*/ */
export interface Adapters { export interface Adapters {
[key: string]: any; [key: string]: any;

2
src/ui/public/vis/request_handlers/courier.js
View file

@ -87,7 +87,7 @@ const CourierRequestHandlerProvider = function () {
aggs.setTimeRange(timeRange); aggs.setTimeRange(timeRange);
// For now we need to mirror the history of the passed search source, since // For now we need to mirror the history of the passed search source, since
// the spy panel wouldn't work otherwise. // the request inspector wouldn't work otherwise.
Object.defineProperty(requestSearchSource, 'history', { Object.defineProperty(requestSearchSource, 'history', {
get() { get() {
return searchSource.history; return searchSource.history;

6
src/ui/public/visualize/loader/__tests__/visualize_loader.js
View file

@ -185,12 +185,6 @@ describe('visualize loader', () => {
expect(vis.attr('data-foo')).to.be(''); expect(vis.attr('data-foo')).to.be('');
expect(vis.attr('data-with-dash')).to.be('value'); expect(vis.attr('data-with-dash')).to.be('value');
}); });
it('should hide spy panel control by default', () => {
const vis = embedWithParams({});
expect(vis.find('[data-test-subj="spyToggleButton"]').length).to.be(0);
});
}); });
describe('embedVisualizationWithId', () => { describe('embedVisualizationWithId', () => {

2
test/functional/apps/visualize/_tile_map.js
View file

@ -33,7 +33,6 @@ export default function ({ getService, getPageObjects }) {
before(async function () { before(async function () {
// Make sure the window is height enough to show the spy panel without hiding the map
remote.setWindowSize(1280, 1000); remote.setWindowSize(1280, 1000);
const fromTime = '2015-09-19 06:31:44.000'; const fromTime = '2015-09-19 06:31:44.000';
@ -64,7 +63,6 @@ export default function ({ getService, getPageObjects }) {
describe('complete config', function describeIndexTests() { describe('complete config', function describeIndexTests() {
before(async function () { before(async function () {
// Make sure the window is height enough to show the spy panel without hiding the map
remote.setWindowSize(1280, 1000); remote.setWindowSize(1280, 1000);
const fromTime = '2015-09-19 06:31:44.000'; const fromTime = '2015-09-19 06:31:44.000';