maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use lt instead of lte for safer upper bound in range filter.

Browse source 
Using lte with +interval -1ms assumes that 1ms is the smallest delta possible.
This may be true today but may not stay true in the future. It is safer to
use lt with +interval instead.
This commit is contained in:
Shaunak Kashyap 2016-05-04 08:31:24 -07:00
parent 6d543b48d6
commit 356b39e139
No known key found for this signature in database
GPG key ID: 0512E188DDE4FF2A
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/ui/public/agg_types/__tests__/buckets/create_filter/date_histogram.js
View file

@ -72,13 +72,13 @@ describe('AggConfig Filters', function () {
expect(fieldParams).to.have.property('gte');
expect(fieldParams.gte).to.be.a('number');
expect(fieldParams).to.have.property('lte');
expect(fieldParams.lte).to.be.a('number');
expect(fieldParams).to.have.property('lt');
expect(fieldParams.lt).to.be.a('number');
expect(fieldParams).to.have.property('format');
expect(fieldParams.format).to.be('epoch_millis');
expect(fieldParams.gte).to.be.lessThan(fieldParams.lte);
expect(fieldParams.gte).to.be.lessThan(fieldParams.lt);
expect(filter).to.have.property('meta');
expect(filter.meta).to.have.property('index', vis.indexPattern.id);
@ -102,7 +102,7 @@ describe('AggConfig Filters', function () {
let params = filter.range[field.name];
expect(params.gte).to.be(+bucketStart);
expect(params.lte).to.be(+bucketStart.clone().add(interval).subtract(1, 'ms'));
expect(params.lt).to.be(+bucketStart.clone().add(interval));
});
});
});

2
src/ui/public/agg_types/buckets/create_filter/date_histogram.js
View file

@ -8,7 +8,7 @@ export default function createDateHistogramFilterProvider(Private) {
return buildRangeFilter(agg.params.field, {
gte: start.valueOf(),
lte: start.add(interval).subtract(1, 'ms').valueOf(),
lt: start.add(interval).valueOf(),
format: 'epoch_millis'
}, agg.vis.indexPattern);
};