maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Lens] fix transition date_histogram/last_value -> top values/last_value (#86429) (#86457)

Browse source
This commit is contained in:
Marta Bondyra 2020-12-18 17:19:10 +01:00 committed by GitHub
parent c965ed3b72
commit 38c5cde800
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/index.tsx
View file

@ -90,7 +90,8 @@ export const termsOperation: OperationDefinition<TermsIndexPatternColumn, 'field
buildColumn({ layer, field, indexPattern }) {
const existingMetricColumn = Object.entries(layer.columns)
.filter(
([columnId, column]) => column && !column.isBucketed && !isReferenced(layer, columnId)
([columnId, column]) =>
column && !isReferenced(layer, columnId) && isSortableByColumn(column)
)
.map(([id]) => id)[0];

33
x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/terms.test.tsx
View file

@ -305,7 +305,7 @@ describe('terms', () => {
expect(termsColumn.params.otherBucket).toEqual(false);
});
it('should use existing metric column as order column', () => {
it('should use existing sortable metric column as order column', () => {
const termsColumn = termsOperation.buildColumn({
indexPattern: createMockedIndexPattern(),
layer: {
@ -335,6 +335,37 @@ describe('terms', () => {
})
);
});
it('should set alphabetical order type if metric column is of type last value', () => {
const termsColumn = termsOperation.buildColumn({
indexPattern: createMockedIndexPattern(),
layer: {
columns: {
col1: {
label: 'Last value of a',
dataType: 'number',
isBucketed: false,
sourceField: 'a',
operationType: 'last_value',
params: {
sortField: 'datefield',
},
},
},
columnOrder: [],
indexPatternId: '',
},
field: {
aggregatable: true,
searchable: true,
type: 'boolean',
name: 'test',
displayName: 'test',
},
});
expect(termsColumn.params).toEqual(
expect.objectContaining({ orderBy: { type: 'alphabetical' } })
);
});
it('should use the default size when there is an existing bucket', () => {
const termsColumn = termsOperation.buildColumn({