maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Disable missing terms for non string fields (#17455)

Browse source 
* Disable missing terms for non string fields

* Disable setting instead of hiding them
This commit is contained in:
Tim Roes 2018-03-30 22:46:50 +02:00 committed by GitHub
parent 622d3f333b
commit 3a30d0bf76
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/ui/public/agg_types/buckets/terms.js
View file

@ -152,6 +152,12 @@ export function AggTypesBucketsTermsProvider(Private) {
return aggFilter.includes(`!${agg.type.name}`);
};
$scope.$watch('agg.params.field.type', (type) => {
if (type !== 'string') {
$scope.agg.params.missingBucket = false;
}
});
function updateOrderAgg() {
// abort until we get the responseValueAggs
if (!$scope.responseValueAggs) return;
@ -201,7 +207,7 @@ export function AggTypesBucketsTermsProvider(Private) {
output.params.valueType = agg.getField().type === 'number' ? 'float' : agg.getField().type;
}
if (agg.params.missingBucket) {
if (agg.params.missingBucket && agg.params.field.type === 'string') {
output.params.missing = '__missing__';
}

4
src/ui/public/agg_types/controls/order_and_size.html
View file

@ -63,11 +63,12 @@
class="kuiCheckBox"
name="showMissing"
ng-model="agg.params.missingBucket"
ng-disabled="agg.params.field.type !== 'string'"
>
Show missing values
<icon-tip
position="'right'"
content="'When enabled, include documents with missing values in the search. If this bucket is in the top N, it appears in the chart. If not in the top N, and you enable \'Group other values in separate bucket\', Elasticsearch adds the missing values to the \'other\' bucket.'"
content="'Only works for fields of type \'string\'. When enabled, include documents with missing values in the search. If this bucket is in the top N, it appears in the chart. If not in the top N, and you enable \'Group other values in separate bucket\', Elasticsearch adds the missing values to the \'other\' bucket.'"
></icon-tip>
</label>
</div>
@ -82,6 +83,7 @@
type="text"
ng-model="agg.params.missingBucketLabel"
class="form-control kuiSideBarInput"
ng-disabled="agg.params.field.type !== 'string'"
>
</div>
</div>