maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes the link to advanced settings in the telemetry opt-in notice banner (#52699)

Browse source 
* Prepends base path to the link to advanced settings in the telemetry opt-in notice banner from all apps
This commit is contained in:
Christiane (Tina) Heiligers 2019-12-11 12:18:37 -07:00 committed by GitHub
parent 711b44b7fb
commit 3bb48e67c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/legacy/core_plugins/telemetry/common/constants.ts
View file

@ -70,3 +70,8 @@ export const TELEMETRY_STATS_TYPE = 'telemetry';
* @type {string}
*/
export const UI_METRIC_USAGE_TYPE = 'ui_metric';
/**
* Link to Advanced Settings.
*/
export const PATH_TO_ADVANCED_SETTINGS = 'kibana#/management/kibana/settings';

2
src/legacy/core_plugins/telemetry/public/components/__snapshots__/opted_in_notice_banner.test.tsx.snap generated
View file

@ -10,7 +10,7 @@ exports[`OptInDetailsComponent renders as expected 1`] = `
values={
Object {
"disableLink": <ForwardRef
href="#/management/kibana/settings"
href="kibana#/management/kibana/settings"
onClick={[Function]}
>
<FormattedMessage

7
src/legacy/core_plugins/telemetry/public/components/opted_in_notice_banner.tsx
View file

@ -20,8 +20,10 @@
/* eslint @elastic/eui/href-or-on-click:0 */
import * as React from 'react';
import chrome from 'ui/chrome';
import { EuiButton, EuiLink, EuiCallOut, EuiSpacer } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { PATH_TO_ADVANCED_SETTINGS } from '../../common/constants';
interface Props {
onSeenBanner: () => any;
@ -57,7 +59,10 @@ export class OptedInBanner extends React.PureComponent<Props> {
</EuiLink>
),
disableLink: (
<EuiLink href="#/management/kibana/settings" onClick={this.onLinkClick}>
<EuiLink
href={chrome.addBasePath(PATH_TO_ADVANCED_SETTINGS)}
onClick={this.onLinkClick}
>
<FormattedMessage
id="telemetry.telemetryOptedInDisableUsage"
defaultMessage="disable usage data here"