From 3c32d1c28fe06d88119f34478483daa2f2905774 Mon Sep 17 00:00:00 2001 From: Rashid Khan Date: Fri, 16 May 2014 15:42:03 -0700 Subject: [PATCH] Make server listen on all interfaces, makes mobile testing easier --- src/kibana/apps/visualize/directives/visualize.js | 14 ++++++++------ .../visualize/saved_visualizations/_type_defs.js | 6 ++++++ tasks/config/connect.js | 1 + 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/kibana/apps/visualize/directives/visualize.js b/src/kibana/apps/visualize/directives/visualize.js index 19a3b5b642f1..2c569314d6d5 100644 --- a/src/kibana/apps/visualize/directives/visualize.js +++ b/src/kibana/apps/visualize/directives/visualize.js @@ -18,11 +18,11 @@ define(function (require) { link: function ($scope, $el) { var chart; // set in "vis" watcher - function onHover(event) { - console.log(event); - } + $scope.$watch('vis', function (vis, prevVis) { + var typeDefinition = typeDefs.byName[vis.typeName]; + if (prevVis && prevVis.destroy) prevVis.destroy(); if (chart) { chart.off('hover'); @@ -40,12 +40,14 @@ define(function (require) { }; _.merge(vis.params, params); - _.defaults(params, typeDefs.byName[vis.typeName].params); + _.defaults(params, typeDefinition.params); chart = new k4d3.Chart($el[0], params); - chart.on('hover', onHover); - chart.on('click', onHover); + if (!!typeDefinition.onHover) chart.on('hover', typeDefinition.onHover); + if (!!typeDefinition.onClick) chart.on('click', typeDefinition.onClick); + if (!!typeDefinition.onBrush) chart.on('brush', typeDefinition.onBrush); + vis.searchSource.onResults(function onResults(resp) { courier.indexPatterns.get(vis.searchSource.get('index')) diff --git a/src/kibana/apps/visualize/saved_visualizations/_type_defs.js b/src/kibana/apps/visualize/saved_visualizations/_type_defs.js index e5c4cdbe60a7..b00cd36f2124 100644 --- a/src/kibana/apps/visualize/saved_visualizations/_type_defs.js +++ b/src/kibana/apps/visualize/saved_visualizations/_type_defs.js @@ -11,6 +11,12 @@ define(function (require) { addTooltip: true, addLegend: true }, + onClick: function (e) { + console.log('click', e); + }, + onHover: function (e) { + console.log('hover', e); + }, config: { metric: { label: 'Y-Axis', diff --git a/tasks/config/connect.js b/tasks/config/connect.js index 11bb8a1e5e84..65b88337e4a4 100644 --- a/tasks/config/connect.js +++ b/tasks/config/connect.js @@ -5,6 +5,7 @@ module.exports = function (grunt) { return { dev: { options: { + hostname: '0.0.0.0', middleware: function (connect, options, stack) { stack = stack || [];