maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SECURITY] Copy saved object flyout should not allow copying into the active space (#116657)

Browse source 
* copy saved object flyout should not allow copying into the active space

* stupid me
This commit is contained in:
Xavier Mouligneau 2021-10-29 13:55:17 -04:00 committed by GitHub
parent 45476dcbe6
commit 3f91556e67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout_internal.test.tsx
View file

@ -112,8 +112,7 @@ const setup = async (opts: SetupOpts = {}) => {
return { wrapper, onClose, mockSpacesManager, mockToastNotifications, savedObjectToCopy };
};
// flaky https://github.com/elastic/kibana/issues/96708
describe.skip('CopyToSpaceFlyout', () => {
describe('CopyToSpaceFlyout', () => {
it('waits for spaces to load', async () => {
const { wrapper } = await setup({ returnBeforeSpacesLoad: true });

2
x-pack/plugins/spaces/public/copy_saved_objects_to_space/components/copy_to_space_flyout_internal.tsx
View file

@ -75,7 +75,7 @@ export const CopyToSpaceFlyoutInternal = (props: CopyToSpaceFlyoutProps) => {
isLoading: false,
spaces: [...spacesMap.values()].filter(
({ isActiveSpace, isAuthorizedForPurpose }) =>
isActiveSpace || isAuthorizedForPurpose('copySavedObjectsIntoSpace')
!isActiveSpace && isAuthorizedForPurpose('copySavedObjectsIntoSpace')
),
});
})