Merge pull request #6593 from tylersmalley/feature/design-test-2

[K5] Resolves test failures for feature/design branch

docs/advanced-settings.asciidoc

@@ -1,6 +1,8 @@
 [[kibana-settings-reference]]
 
-WARNING: Modifying the following settings can signficantly affect Kibana's performance and cause problems that are difficult to diagnose. Setting a property's value to a blank field will revert to the default behavior, which may not be compatible with other configuration settings. Deleting a custom setting removes it from Kibana permanently.
+WARNING: Modifying the following settings can signficantly affect Kibana's performance and cause problems that are 
+difficult to diagnose. Setting a property's value to a blank field will revert to the default behavior, which may not be 
+compatible with other configuration settings. Deleting a custom setting removes it from Kibana permanently.
 
 .Kibana Settings Reference
 [horizontal]
@@ -8,30 +10,43 @@ WARNING: Modifying the following settings can signficantly affect Kibana's perfo
 `sort:options`:: Options for the Elasticsearch https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html[sort] parameter.
 `dateFormat`:: The format to use for displaying pretty-formatted dates.
 `dateFormat:tz`:: The timezone that Kibana uses. The default value of `Browser` uses the timezone detected by the browser.
-`dateFormat:scaled`:: These values define the format used to render ordered time-based data. Formatted timestamps must adapt to the interval between measurements. Keys are http://en.wikipedia.org/wiki/ISO_8601#Time_intervals[ISO8601 intervals].
+`dateFormat:scaled`:: These values define the format used to render ordered time-based data. Formatted timestamps must 
+adapt to the interval between measurements. Keys are http://en.wikipedia.org/wiki/ISO_8601#Time_intervals[ISO8601 intervals].
 `defaultIndex`:: Default is `null`. This property specifies the default index.
-`metaFields`:: An array of fields outside of `_source`. Kibana merges these fields into the document when displaying the document.
+`metaFields`:: An array of fields outside of `_source`. Kibana merges these fields into the document when displaying the 
+document.
 `discover:sampleSize`:: The number of rows to show in the Discover table.
-`doc_table:highlight`:: Highlight results in Discover and Saved Searches Dashboard. Highlighing makes request slow when working on big documents. Set this property to `false` to disable highlighting.
-`courier:maxSegmentCount`:: Kibana splits requests in the Discover app into segments to limit the size of requests sent to the Elasticsearch cluster. This setting constrains the length of the segment list. Long segment lists can significantly increase request processing time.
+`doc_table:highlight`:: Highlight results in Discover and Saved Searches Dashboard. Highlighing makes request slow when 
+working on big documents. Set this property to `false` to disable highlighting.
+`courier:maxSegmentCount`:: Kibana splits requests in the Discover app into segments to limit the size of requests sent to 
+the Elasticsearch cluster. This setting constrains the length of the segment list. Long segment lists can significantly 
+increase request processing time.
 `fields:popularLimit`:: This setting governs how many of the top most popular fields are shown.
 `histogram:barTarget`:: When date histograms use the `auto` interval, Kibana attempts to generate this number of bars.
-`histogram:maxBars`:: Date histograms are not generated with more bars than the value of this property, scaling values when necessary.
-`visualization:tileMap:maxPrecision`:: The maximum geoHash precision displayed on tile maps: 7 is high, 10 is very high, 12 is the maximum. http://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator[Explanation of cell dimensions].
+`histogram:maxBars`:: Date histograms are not generated with more bars than the value of this property, scaling values 
+when necessary.
+`visualization:tileMap:maxPrecision`:: The maximum geoHash precision displayed on tile maps: 7 is high, 10 is very high, 
+12 is the maximum. http://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator[Explanation of cell dimensions].
 `visualization:tileMap:WMSdefaults`:: Default properties for the WMS map server support in the tile map.
 `visualization:colorMapping`:: Maps values to specified colors within visualizations.
 `visualization:loadingDelay`:: Time to wait before dimming visualizations during query.
 `csv:separator`:: A string that serves as the separator for exported values.
 `csv:quoteValues`:: Set this property to `true` to quote exported values.
-`history:limit`:: In fields that have history, such as query inputs, the value of this property limits how many recent values are shown.
-`shortDots:enable`:: Set this property to `true` to shorten long field names in visualizations. For example, instead of `foo.bar.baz`, show `f.b.baz`.
-`truncate:maxHeight`:: This property specifies the maximum height that a cell occupies in a table. A value of 0 disables truncation.
-`indexPattern:fieldMapping:lookBack`:: The value of this property sets the number of recent matching patterns to query the field mapping for index patterns with names that contain timestamps.
-`format:defaultTypeMap`:: A map of the default format name for each field type. Field types that are not explicitly mentioned use "_default_".
+`history:limit`:: In fields that have history, such as query inputs, the value of this property limits how many recent 
+values are shown.
+`shortDots:enable`:: Set this property to `true` to shorten long field names in visualizations. For example, instead of 
+`foo.bar.baz`, show `f.b.baz`.
+`truncate:maxHeight`:: This property specifies the maximum height that a cell occupies in a table. A value of 0 disables 
+truncation.
+`indexPattern:fieldMapping:lookBack`:: The value of this property sets the number of recent matching patterns to query the 
+field mapping for index patterns with names that contain timestamps.
+`format:defaultTypeMap`:: A map of the default format name for each field type. Field types that are not explicitly 
+mentioned use "_default_".
 `format:number:defaultPattern`:: Default numeral format for the "number" format.
 `format:bytes:defaultPattern`:: Default numeral format for the "bytes" format.
 `format:percent:defaultPattern`:: Default numeral format for the "percent" format.
 `format:currency:defaultPattern`:: Default numeral format for the "currency" format.
+`savedObjects:perPage`:: The number of objects shown on each page of the list of saved objects. The default value is 5.
 `timepicker:timeDefaults`:: The default time filter selection.
 `timepicker:refreshIntervalDefaults`:: The time filter's default refresh interval.
-`dashboard:defaultDarkTheme`:: Set this property to `true` to make new dashboards use the dark theme by default.
+`dashboard:defaultDarkTheme`:: Set this property to `true` to make new dashboards use the dark theme by default.

docs/datatable.asciidoc

@@ -45,6 +45,8 @@ sub-aggregation from the list of types.
 
 You can use the up or down arrows to the right of the aggregation's type to change the aggregation's priority.
 
+Enter a string in the *Custom Label* field to change the display label.
+
 You can click the *Advanced* link to display more customization options for your metrics or bucket aggregation:
 
 *Exclude Pattern*:: Specify a pattern in this field to exclude from the results.

docs/metric.asciidoc

@@ -4,6 +4,7 @@
 A metric visualization displays a single number for each aggregation you select:
 
 include::y-axis-aggs.asciidoc[]
+
 You can click the *Advanced* link to display more customization options:
 
 *JSON Input*:: A text field where you can add specific JSON-formatted properties to merge with the aggregation 
@@ -17,7 +18,7 @@ NOTE: In Elasticsearch releases 1.4.3 and later, this functionality requires you
 
 The availability of these options varies depending on the aggregation you choose.
 
-Click the *Options* tab to change the font used to display the metrics.
+Click the *Options* tab to display the font size slider.
 
 [float]
 [[metric-viewing-detailed-information]]

docs/pie.asciidoc

@@ -11,6 +11,8 @@ field. Select a field from the drop-down.
 *Unique Count*:: The {ref}search-aggregations-metrics-cardinality-aggregation.html[_cardinality_] aggregation returns 
 the number of unique values in a field. Select a field from the drop-down.
 
+Enter a string in the *Custom Label* field to change the display label.
+
 The _buckets_ aggregations determine what information is being retrieved from your data set.
 
 Before you choose a buckets aggregation, specify if you are splitting slices within a single chart or splitting into
@@ -57,6 +59,8 @@ aggregation's type to change the aggregation's priority.
 
 include::color-picker.asciidoc[]
 
+Enter a string in the *Custom Label* field to change the display label.
+
 You can click the *Advanced* link to display more customization options for your metrics or bucket aggregation:
 
 *Exclude Pattern*:: Specify a pattern in this field to exclude from the results.

docs/plugins.asciidoc

@@ -65,6 +65,11 @@ bin/kibana plugin --remove marvel
 
 You can also remove a plugin manually by deleting the plugin's subdirectory under the `installedPlugins` directory.
 
+[float]
+=== Listing Installed Plugins
+
+Use `--list` or `-l` option to list the currently installed plugins.
+
 [float]
 === Updating Plugins
 

docs/tilemap.asciidoc

@@ -19,6 +19,8 @@ numeric field. Select a field from the drop-down.
 *Unique Count*:: The {ref}search-aggregations-metrics-cardinality-aggregation.html[_cardinality_] aggregation returns 
 the number of unique values in a field. Select a field from the drop-down.
 
+Enter a string in the *Custom Label* field to change the display label.
+
 The _buckets_ aggregations determine what information is being retrieved from your data set.
 
 Before you choose a buckets aggregation, specify if you are splitting the chart or displaying the buckets as *Geo 
@@ -71,6 +73,8 @@ based on the geohash coordinates.
 
 NOTE: By default, the *Change precision on map zoom* box is checked. Uncheck the box to disable this behavior.
 
+Enter a string in the *Custom Label* field to change the display label.
+
 You can click the *Advanced* link to display more customization options for your metrics or bucket aggregation:
 
 *Exclude Pattern*:: Specify a pattern in this field to exclude from the results.

docs/vertbar.asciidoc

@@ -26,6 +26,8 @@ values field. Click *+Add* to add a values field.
 
 You can add an aggregation by clicking the *+ Add Aggregation* button.
 
+Enter a string in the *Custom Label* field to change the display label.
+
 The _buckets_ aggregations determine what information is being retrieved from your data set.
 
 Before you choose a buckets aggregation, specify if you are splitting slices within a single chart or splitting into
@@ -36,6 +38,8 @@ include::x-axis-aggs.asciidoc[]
 
 include::color-picker.asciidoc[]
 
+Enter a string in the *Custom Label* field to change the display label.
+
 You can click the *Advanced* link to display more customization options for your metrics or bucket aggregation:
 
 *Exclude Pattern*:: Specify a pattern in this field to exclude from the results.

docs/x-axis-aggs.asciidoc

@@ -28,8 +28,8 @@ remove a range.
 or bottom _n_ elements of a  given field to display, ordered by count or a custom metric.
 *Filters*:: You can specify a set of {ref}/search-aggregations-bucket-filters-aggregation.html[_filters_] for the data. 
 You can specify a filter as a query string or in JSON format, just as in the Discover search bar. Click *Add Filter* to 
-add another filter. Click the image:images/labelbutton.png[] *label* button to open the label field, where you can type in a 
-name to display on the visualization.
+add another filter. Click the image:images/labelbutton.png[Label button icon] *label* button to open the label field, where 
+you can type in a name to display on the visualization.
 *Significant Terms*:: Displays the results of the experimental 
 {ref}/search-aggregations-bucket-significantterms-aggregation.html[_significant terms_] aggregation.
 
@@ -39,3 +39,5 @@ from the list of types.
 
 When multiple aggregations are defined on a chart's axis, you can use the up or down arrows to the right of the 
 aggregation's type to change the aggregation's priority.
+
+Enter a string in the *Custom Label* field to change the display label.

docs/y-axis-aggs.asciidoc

@@ -22,3 +22,5 @@ from the drop-down, then specify one or more percentile rank values in the *Valu
 values field. Click *+Add* to add a values field.
 
 You can add an aggregation by clicking the *+ Add Aggregation* button.
+
+Enter a string in the *Custom Label* field to change the display label.

src/ui/public/agg_types/metrics/percentile_ranks.js

@@ -37,6 +37,11 @@ export default function AggTypeMetricPercentileRanksProvider(Private) {
         name: 'values',
         editor: valuesEditor,
         default: []
+      },
+      {
+        write(agg, output) {
+          output.params.keyed = false;
+        }
       }
     ],
     getResponseAggs: function (agg) {

src/ui/public/agg_types/metrics/percentiles.js

@@ -35,6 +35,11 @@ export default function AggTypeMetricPercentilesProvider(Private) {
         name: 'percents',
         editor: percentsEditor,
         default: [1, 5, 25, 50, 75, 95, 99]
+      },
+      {
+        write(agg, output) {
+          output.params.keyed = false;
+        }
       }
     ],
     getResponseAggs: function (agg) {

src/ui/public/index_patterns/__tests__/_field_format.js

@@ -85,8 +85,8 @@ describe('FieldFormat class', function () {
         var text = f.getConverterFor('text');
         var html = f.getConverterFor('html');
         expect(text).to.not.be(html);
-        expect(text()).to.be('formatted');
-        expect(html()).to.be('formatted');
+        expect(text('formatted')).to.be('formatted');
+        expect(html('formatted')).to.be('formatted');
       });
 
       it('can be an object, with seperate text and html converter', function () {
@@ -99,8 +99,8 @@ describe('FieldFormat class', function () {
         var text = f.getConverterFor('text');
         var html = f.getConverterFor('html');
         expect(text).to.not.be(html);
-        expect(text()).to.be('formatted text');
-        expect(html()).to.be('formatted html');
+        expect(text('formatted text')).to.be('formatted text');
+        expect(html('formatted html')).to.be('formatted html');
       });
 
       it('does not escape the output of the text converter', function () {
@@ -147,6 +147,11 @@ describe('FieldFormat class', function () {
         var f = new TestFormat();
         expect(f.convert('val', 'html')).to.be('html');
       });
+
+      it('formats a value as " - " when no value is specified', function () {
+        var f = new TestFormat();
+        expect(f.convert()).to.be(' - ');
+      });
     });
 
   });

src/ui/public/index_patterns/_field_format/content_types.js

@@ -6,6 +6,10 @@ export default function contentTypesProvider(highlightFilter) {
   var types = {
     html: function (format, convert) {
       return function recurse(value, field, hit) {
+        if (value == null) {
+          return _.asPrettyString(value);
+        }
+
         if (!value || typeof value.map !== 'function') {
           return convert.call(format, value, field, hit);
         }

tasks/config/downloadSelenium.js

@@ -1,14 +1,18 @@
 var path = require('path');
+import { resolve as resolveUrl } from 'url';
 
+const URL = 'https://selenium-release.storage.googleapis.com/2.48/selenium-server-standalone-2.48.2.jar';
+const DIR = resolveUrl(URL, './');
+const FILE = URL.replace(DIR, '');
 
 module.exports = function (grunt) {
   return {
     options: {
       selenium: {
-        filename: 'selenium-server-standalone-2.48.2.jar',
-        server: 'https://selenium-release.storage.googleapis.com/2.48/',
+        filename: FILE,
+        server: DIR,
         md5: 'b2784fc67c149d3c13c83d2108104689',
-        directory: path.join(grunt.config.get('root'), 'selenium')
+        path: path.join(grunt.config.get('root'), 'selenium', FILE)
       }
     }
   };

tasks/config/run.js

@@ -122,7 +122,7 @@ module.exports = function (grunt) {
       cmd: 'java',
       args: [
         '-jar',
-        'selenium/selenium-server-standalone-2.48.2.jar',
+        '<%= downloadSelenium.options.selenium.path %>',
         '-port',
         uiConfig.servers.webdriver.port,
       ]
@@ -138,7 +138,7 @@ module.exports = function (grunt) {
       cmd: 'java',
       args: [
         '-jar',
-        'selenium/selenium-server-standalone-2.48.2.jar',
+        '<%= downloadSelenium.options.selenium.path %>',
         '-port',
         uiConfig.servers.webdriver.port,
       ]

tasks/download_selenium.js

@@ -11,8 +11,9 @@ module.exports = function (grunt) {
     const done = this.async();
     const config = this.options();
 
-    const SELENIUM_FILE_PATH = path.join(config.selenium.directory, config.selenium.filename);
-    const SELENIUM_DOWNLOAD_URL = config.selenium.server + config.selenium.filename;
+    const FILE = config.selenium.path;
+    const DIR = path.dirname(config.selenium.path);
+    const URL = config.selenium.server + config.selenium.filename;
 
     function validateDownload(path, expectedHash, success) {
       grunt.log.write('Validating hash...');
@@ -28,27 +29,27 @@ module.exports = function (grunt) {
     }
 
     function downloadSelenium(success) {
-      grunt.log.write(`Downloading ${SELENIUM_DOWNLOAD_URL}...`);
-      request.get(SELENIUM_DOWNLOAD_URL)
-      .pipe(fs.createWriteStream(SELENIUM_FILE_PATH))
+      grunt.log.write(`Downloading ${URL}...`);
+      request.get(URL)
+      .pipe(fs.createWriteStream(FILE))
       .on('error', function downloadError(err) {
         grunt.fail.warn(err);
       })
       .on('finish', function downloadFinish() {
         grunt.log.writeln('done');
-        validateDownload(SELENIUM_FILE_PATH, config.selenium.md5, success);
+        validateDownload(FILE, config.selenium.md5, success);
       });
     }
 
     function start() {
       try {
-        fs.mkdirSync(config.selenium.directory);
+        fs.mkdirSync(DIR);
       } catch (err) {
         if (err && err.code !== 'EEXIST') grunt.fail.warn(err);
       }
 
-      if (fs.existsSync(SELENIUM_FILE_PATH)) {
-        validateDownload(SELENIUM_FILE_PATH, config.selenium.md5, done);
+      if (fs.existsSync(FILE)) {
+        validateDownload(FILE, config.selenium.md5, done);
       } else {
         downloadSelenium(done);
       }

tasks/jenkins.js

@@ -1,7 +1,18 @@
+import { compact } from 'lodash';
+import { delimiter } from 'path';
+
 module.exports = function (grunt) {
-  let { compact } = require('lodash');
   grunt.registerTask('jenkins', 'Jenkins build script', function () {
-    process.env.JAVA_HOME = '/usr/lib/jvm/jdk8';
+    // make sure JAVA_HOME points to JDK8
+    const HOME = '/usr/lib/jvm/jdk8';
+    process.env.JAVA_HOME = HOME;
+
+    // extend PATH to point to JDK8
+    const path = process.env.PATH.split(delimiter);
+    path.unshift(`${HOME}/bin`);
+    process.env.PATH = path.join(delimiter);
+
+    // always build os packages on jenkins
     grunt.option('os-packages', true);
 
     grunt.task.run(compact([

test/functional/apps/discover/_field_data.js

@@ -141,7 +141,7 @@ define(function (require) {
             + ' Here’s...", "twitter:card": "summary", "twitter:image": "'
             + 'http://IMAGES1.laweekly.com/imager/the-rapture-at-the-mayan-7-25/u/original/2463272/rapturetn05.jpg",'
             + ' "twitter:site": "@laweekly" } machine.os:win 7 machine.ram:7,516,192,768 _id:AU_x3_g4GFA8no6QjkYX'
-            + ' _type:apache _index:logstash-2015.09.22 _score: relatedContent.article:modified_time:November 27th'
+            + ' _type:apache _index:logstash-2015.09.22 _score: - relatedContent.article:modified_time:November 27th'
             + ' 2014, 16:00:51.000, November 27th 2014, 16:28:42.000 relatedContent.article:published_time:July 26th'
             + ' 2007, 19:42:30.000, December 13th 2007, 20:19:35.000';
           return discoverPage.getDocTableIndex(1)
@@ -219,7 +219,7 @@ define(function (require) {
             + ' "Arts", "og:site_name": "LA Weekly", "twitter:title": "Shopping Daze", "twitter:description": "LA'
             + ' Weekly is the definitive source of information for news, music, movies, restaurants, reviews, and'
             + ' events in Los Angeles.", "twitter:card": "summary", "twitter:site": "@laweekly" } machine.os:osx'
-            + ' machine.ram:15,032,385,536 _id:AU_x3_g3GFA8no6QjkFm _type:apache _index:logstash-2015.09.20 _score:'
+            + ' machine.ram:15,032,385,536 _id:AU_x3_g3GFA8no6QjkFm _type:apache _index:logstash-2015.09.20 _score: -'
             + ' relatedContent.article:modified_time:October 28th 2014, 22:00:08.000, November 26th 2014,'
             + ' 01:05:47.000, November 26th 2014, 03:52:35.000, November 26th 2014, 04:15:21.000, November 27th 2014,'
             + ' 16:01:03.000 relatedContent.article:published_time:October 21st 2005, 01:10:25.000, March 5th 2006,'

test/support/pages/visualize_page.js

@@ -326,6 +326,33 @@ define(function (require) {
       });
     },
 
+    clickLoadSavedVisButton: function clickLoadSavedVisButton() {
+      return this.remote
+        .setFindTimeout(defaultTimeout)
+        .findDisplayedByCssSelector('button[aria-label="Load Saved Visualization"]')
+        .click();
+    },
+
+    filterVisByName: function filterVisByName(vizName) {
+      return this.remote
+        .findByCssSelector('input[name="filter"]')
+        .click()
+        // can't uses dashes in saved visualizations when filtering
+        // or extended character sets
+        // https://github.com/elastic/kibana/issues/6300
+        .type(vizName.replace('-',' '));
+    },
+
+    clickVisualizationByLinkText: function clickVisualizationByLinkText(vizName) {
+      var self = this;
+      common.debug('clickVisualizationByLinkText(' + vizName + ')');
+
+      return this.remote
+        .setFindTimeout(defaultTimeout)
+        .findByLinkText(vizName)
+        .click();
+    },
+
     // this starts by clicking the Load Saved Viz button, not from the
     // bottom half of the "Create a new visualization      Step 1" page
     loadSavedVisualization: function loadSavedVisualization(vizName) {