maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Add summary call out to total feature importance if it's empty (#79546)

Browse source
This commit is contained in:
Quynh Nguyen 2020-10-06 11:40:39 -05:00 committed by GitHub
parent 9a58893428
commit 445a7908c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
x-pack/plugins/ml/public/application/data_frame_analytics/common/use_results_view_config.ts
View file

@ -80,10 +80,7 @@ export const useResultsViewConfig = (jobId: string) => {
const inferenceModel = inferenceModels.find(
(model) => model.metadata?.analytics_config?.id === jobId
);
if (
Array.isArray(inferenceModel?.metadata?.total_feature_importance) === true &&
inferenceModel?.metadata?.total_feature_importance.length > 0
) {
if (Array.isArray(inferenceModel?.metadata?.total_feature_importance) === true) {
setTotalFeatureImportance(inferenceModel?.metadata?.total_feature_importance);
}
} catch (e) {

73
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/total_feature_importance_summary/feature_importance_summary.tsx
View file

@ -5,7 +5,7 @@
*/
import React, { FC, useCallback, useMemo } from 'react';
import { EuiButtonEmpty, EuiSpacer } from '@elastic/eui';
import { EuiButtonEmpty, EuiSpacer, EuiCallOut } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import {
Chart,
@ -188,9 +188,14 @@ export const FeatureImportanceSummaryPanel: FC<FeatureImportanceSummaryPanelProp
const { ELASTIC_WEBSITE_URL, DOC_LINK_VERSION } = docLinks;
const tickFormatter = useCallback((d) => Number(d.toPrecision(3)).toString(), []);
// do not expand by default if no feature importance data
const hasTotalFeatureImportance = useMemo(() => totalFeatureImportance.length > 1, [
totalFeatureImportance,
]);
return (
<>
<ExpandableSection
isExpanded={hasTotalFeatureImportance}
dataTestId="FeatureImportanceSummary"
title={
<FormattedMessage
@ -219,34 +224,46 @@ export const FeatureImportanceSummaryPanel: FC<FeatureImportanceSummaryPanelProp
},
]}
content={
<Chart
size={{
width: '100%',
height: chartHeight,
}}
>
<Settings rotation={90} theme={theme} showLegend={showLegend} />
!hasTotalFeatureImportance ? (
<EuiCallOut
size="s"
title={
<FormattedMessage
id="xpack.ml.dataframe.analytics.exploration.noTotalFeatureImportanceCalloutMessage"
defaultMessage="Total feature importance data is not available; the data set is uniform and the features have no significant impact on the prediction."
/>
}
/>
) : (
<Chart
size={{
width: '100%',
height: chartHeight,
}}
>
<Settings rotation={90} theme={theme} showLegend={showLegend} />
<Axis
id="x-axis"
title={i18n.translate(
'xpack.ml.dataframe.analytics.exploration.featureImportanceXAxisTitle',
{
defaultMessage: 'Feature importance average magnitude',
}
)}
position={Position.Bottom}
tickFormat={tickFormatter}
/>
<Axis id="y-axis" title="" position={Position.Left} />
<BarSeries
id="magnitude"
xScaleType={ScaleType.Ordinal}
yScaleType={ScaleType.Linear}
data={plotData}
{...barSeriesSpec}
/>
</Chart>
<Axis
id="x-axis"
title={i18n.translate(
'xpack.ml.dataframe.analytics.exploration.featureImportanceXAxisTitle',
{
defaultMessage: 'Feature importance average magnitude',
}
)}
position={Position.Bottom}
tickFormat={tickFormatter}
/>
<Axis id="y-axis" title="" position={Position.Left} />
<BarSeries
id="magnitude"
xScaleType={ScaleType.Ordinal}
yScaleType={ScaleType.Linear}
data={plotData}
{...barSeriesSpec}
/>
</Chart>
)
}
/>
<EuiSpacer size="m" />