maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[SECURITY] rename server plugin to siem (#69044)

Browse source 
* rename server plugin to siem to avoid privilege issue

* review from alerting

* missing change with rename

* fix tests

* missing api integration test

* fix api integration spaces
This commit is contained in:
Xavier Mouligneau 2020-06-15 09:16:52 -04:00 committed by GitHub
parent 4e864268ce
commit 46ed40ec07
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 36 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/security_solution/common/constants.ts
View file

@ -5,6 +5,7 @@
*/
export const APP_ID = 'securitySolution';
export const SERVER_APP_ID = 'siem';
export const APP_NAME = 'Security';
export const APP_ICON = 'securityAnalyticsApp';
export const APP_PATH = `/app/security`;

2
x-pack/plugins/security_solution/public/alerts/components/user_info/index.test.tsx
View file

@ -22,7 +22,7 @@ describe('useUserInfo', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},

4
x-pack/plugins/security_solution/public/alerts/components/user_info/index.tsx
View file

@ -163,9 +163,7 @@ export const useUserInfo = (): State => {
const uiCapabilities = useKibana().services.application.capabilities;
const capabilitiesCanUserCRUD: boolean =
typeof uiCapabilities.securitySolution.crud === 'boolean'
? uiCapabilities.securitySolution.crud
: false;
typeof uiCapabilities.siem.crud === 'boolean' ? uiCapabilities.siem.crud : false;
useEffect(() => {
if (loading !== privilegeLoading || indexNameLoading) {

8
x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts
View file

@ -113,13 +113,9 @@ export const useGetUserSavedObjectPermissions = () => {
useEffect(() => {
const capabilitiesCanUserCRUD: boolean =
typeof uiCapabilities.securitySolution.crud === 'boolean'
? uiCapabilities.securitySolution.crud
: false;
typeof uiCapabilities.siem.crud === 'boolean' ? uiCapabilities.siem.crud : false;
const capabilitiesCanUserRead: boolean =
typeof uiCapabilities.securitySolution.show === 'boolean'
? uiCapabilities.securitySolution.show
: false;
typeof uiCapabilities.siem.show === 'boolean' ? uiCapabilities.siem.show : false;
setSavedObjectsPermissions({
crud: capabilitiesCanUserCRUD,
read: capabilitiesCanUserRead,

2
x-pack/plugins/security_solution/public/timelines/components/flyout/header_with_close_button/index.test.tsx
View file

@ -20,7 +20,7 @@ jest.mock('../../../../common/lib/kibana', () => ({
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},

2
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/helpers.test.tsx
View file

@ -18,7 +18,7 @@ jest.mock('../../../../common/lib/kibana', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},

2
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/helpers.tsx
View file

@ -222,7 +222,7 @@ export interface NewTimelineProps {
export const NewTimeline = React.memo<NewTimelineProps>(
({ closeGearMenu, outline = false, timelineId, title = i18n.NEW_TIMELINE }) => {
const uiCapabilities = useKibana().services.application.capabilities;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.securitySolution.crud;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.siem.crud;
const { getButton } = useCreateTimelineButton({
timelineId,

2
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/index.test.tsx
View file

@ -30,7 +30,7 @@ jest.mock('../../../../common/lib/kibana', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},

4
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/new_template_timeline.test.tsx
View file

@ -35,7 +35,7 @@ describe('NewTemplateTimeline', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},
@ -76,7 +76,7 @@ describe('NewTemplateTimeline', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: false,
},
},

2
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/new_template_timeline.tsx
View file

@ -25,7 +25,7 @@ export const NewTemplateTimelineComponent: React.FC<OwnProps> = ({
timelineId = 'timeline-1',
}) => {
const uiCapabilities = useKibana().services.application.capabilities;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.securitySolution.crud;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.siem.crud;
const { getButton } = useCreateTimelineButton({
timelineId,

12
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/properties_right.test.tsx
View file

@ -78,7 +78,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},
@ -129,7 +129,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},
@ -158,7 +158,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},
@ -189,7 +189,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: false,
},
},
@ -236,7 +236,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: false,
},
},
@ -265,7 +265,7 @@ describe('Properties Right', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: false,
},
},

2
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/properties_right.tsx
View file

@ -116,7 +116,7 @@ const PropertiesRightComponent: React.FC<PropertiesRightComponentProps> = ({
usersViewing,
}) => {
const uiCapabilities = useKibana().services.application.capabilities;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.securitySolution.crud;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.siem.crud;
return (
<PropertiesRightStyle alignItems="flexStart" data-test-subj="properties-right" gutterSize="s">
<EuiFlexItem grow={false}>

4
x-pack/plugins/security_solution/public/timelines/pages/timelines_page.test.tsx
View file

@ -30,7 +30,7 @@ describe('TimelinesPageComponent', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: true,
},
},
@ -82,7 +82,7 @@ describe('TimelinesPageComponent', () => {
services: {
application: {
capabilities: {
securitySolution: {
siem: {
crud: false,
},
},

2
x-pack/plugins/security_solution/public/timelines/pages/timelines_page.tsx
View file

@ -42,7 +42,7 @@ export const TimelinesPageComponent: React.FC<OwnProps> = ({ apolloClient }) =>
}, [setImportDataModalToggle]);
const uiCapabilities = useKibana().services.application.capabilities;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.securitySolution.crud;
const capabilitiesCanUserCRUD: boolean = !!uiCapabilities.siem.crud;
return (
<>

4
x-pack/plugins/security_solution/server/lib/detection_engine/notifications/rules_notification_alert_type.ts
View file

@ -6,7 +6,7 @@
import { Logger } from 'src/core/server';
import { schema } from '@kbn/config-schema';
import { NOTIFICATIONS_ID } from '../../../../common/constants';
import { NOTIFICATIONS_ID, SERVER_APP_ID } from '../../../../common/constants';
import { NotificationAlertTypeDefinition } from './types';
import { getSignalsCount } from './get_signals_count';
@ -25,7 +25,7 @@ export const rulesNotificationAlertType = ({
name: 'SIEM notification',
actionGroups: siemRuleActionGroups,
defaultActionGroupId: 'default',
producer: 'siem',
producer: SERVER_APP_ID,
validate: {
params: schema.object({
ruleAlertId: schema.string(),

8
x-pack/plugins/security_solution/server/lib/detection_engine/signals/signal_rule_alert_type.ts
View file

@ -8,7 +8,11 @@
import { Logger, KibanaRequest } from 'src/core/server';
import { SIGNALS_ID, DEFAULT_SEARCH_AFTER_PAGE_SIZE } from '../../../../common/constants';
import {
SIGNALS_ID,
DEFAULT_SEARCH_AFTER_PAGE_SIZE,
SERVER_APP_ID,
} from '../../../../common/constants';
import { isJobStarted, isMlRule } from '../../../../common/machine_learning/helpers';
import { SetupPlugins } from '../../../plugin';
@ -55,7 +59,7 @@ export const signalRulesAlertType = ({
validate: {
params: signalParamsSchema(),
},
producer: 'siem',
producer: SERVER_APP_ID,
async executor({
previousStartedAt,
alertId,

4
x-pack/plugins/security_solution/server/plugin.ts
View file

@ -36,7 +36,7 @@ import { initSavedObjects, savedObjectTypes } from './saved_objects';
import { AppClientFactory } from './client';
import { createConfig$, ConfigType } from './config';
import { initUiSettings } from './ui_settings';
import { APP_ID, APP_ICON } from '../common/constants';
import { APP_ID, APP_ICON, SERVER_APP_ID } from '../common/constants';
import { registerEndpointRoutes } from './endpoint/routes/metadata';
import { registerResolverRoutes } from './endpoint/routes/resolver';
import { registerAlertRoutes } from './endpoint/alerts/routes';
@ -125,7 +125,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
registerPolicyRoutes(router, endpointContext);
plugins.features.registerFeature({
id: APP_ID,
id: SERVER_APP_ID,
name: i18n.translate('xpack.securitySolution.featureRegistry.linkSecuritySolutionTitle', {
defaultMessage: 'Security',
}),

2
x-pack/test/api_integration/apis/features/features/features.ts
View file

@ -110,7 +110,7 @@ export default function ({ getService }: FtrProviderContext) {
'logs',
'maps',
'uptime',
'securitySolution',
'siem',
'ingestManager',
].sort()
);

2
x-pack/test/api_integration/apis/security/privileges.ts
View file

@ -35,7 +35,7 @@ export default function ({ getService }: FtrProviderContext) {
logs: ['all', 'read'],
uptime: ['all', 'read'],
apm: ['all', 'read'],
securitySolution: ['all', 'read'],
siem: ['all', 'read'],
ingestManager: ['all', 'read'],
},
global: ['all', 'read'],

2
x-pack/test/api_integration/apis/security/privileges_basic.ts
View file

@ -33,7 +33,7 @@ export default function ({ getService }: FtrProviderContext) {
logs: ['all', 'read'],
uptime: ['all', 'read'],
apm: ['all', 'read'],
securitySolution: ['all', 'read'],
siem: ['all', 'read'],
ingestManager: ['all', 'read'],
},
global: ['all', 'read'],

2
x-pack/test/api_integration/apis/security_solution/feature_controls.ts
View file

@ -204,7 +204,7 @@ export default function ({ getService }: FtrProviderContext) {
kibana: [
{
feature: {
securitySolution: ['read'],
siem: ['read'],
},
spaces: [space1Id],
},