From a4e6c432e91ed5f2f05f4c619fe8514b7cc9ec37 Mon Sep 17 00:00:00 2001
From: Rashid Khan <rashidkpc@gmail.com>
Date: Thu, 19 Jun 2014 13:55:33 -0700
Subject: [PATCH] Added geo_point icon, added field icons to row details, add
 warning icon if a field is found in source that is not in the mapping

---
 .../partials/discover_field_details.html      |  2 +-
 .../apps/discover/partials/row_details.html   | 20 +++++++++++++++----
 src/kibana/directives/field_name.js           | 13 ++++++++++--
 3 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/src/kibana/apps/discover/partials/discover_field_details.html b/src/kibana/apps/discover/partials/discover_field_details.html
index 0f93fb5e7370..2ca8b6b00b1b 100644
--- a/src/kibana/apps/discover/partials/discover_field_details.html
+++ b/src/kibana/apps/discover/partials/discover_field_details.html
@@ -49,4 +49,4 @@
           disabled="disabled"
           tooltip="This field is not indexed thus unavailable for visualization and search"
           ng-class="field.analyzed ? 'success' : 'warning'"
-          class="sidebar-item-button">Visualize</div>
\ No newline at end of file
+          class="sidebar-item-button">Not Indexed</div>
\ No newline at end of file
diff --git a/src/kibana/apps/discover/partials/row_details.html b/src/kibana/apps/discover/partials/row_details.html
index 68ce9dc3cb98..91289260b4dd 100644
--- a/src/kibana/apps/discover/partials/row_details.html
+++ b/src/kibana/apps/discover/partials/row_details.html
@@ -5,18 +5,30 @@
     <li ng-class="{active: row._mode == 'json'}"><a ng-click="row._mode='json'">JSON</a></li>
   </ul>
 
-  <table class="table table-condensed" ng-show="row._mode == 'table'">
+  <table class="table table-condensed" ng-show="row._mode == 'table'" bindonce>
     <tbody>
       <tr ng-repeat="field in row._fields" bindonce>
-        <td bo-text="field" width="1%" class="discover-table-details-field"></td>
+        <td field-name="field"
+            field-type="mapping[field].type"
+            width="1%"
+            class="discover-table-details-field">
+        </td>
         <td width="1%" class="discover-table-details-buttons">
-          <span ng-show="mapping[field].indexed">
+          <span bo-if="mapping[field].indexed">
             <i ng-click="filter(row, field, '+')" class="fa fa-search-plus"></i>
             <i ng-click="filter(row, field, '-')" class="fa fa-search-minus"></i>
           </span>
         </td>
 
-        <td class="discover-table-details-value"><kbn-truncated orig="{{row._formatted[field] || row[field]}}" length=100></kbn-truncated></td>
+        <td>
+          <i bo-show="!mapping[field]"
+            tooltip-placement="top"
+            tooltip="No cached mapping for this field. Refresh your mapping from the Settings > Indices page"
+            class="fa fa-warning text-color-warning ng-scope"></i>
+          <kbn-truncated class="discover-table-details-value"
+            orig="{{row._formatted[field] || row[field]}}"
+            length=100></kbn-truncated>
+        </td>
       </tr>
     </tbody>
   </table>
diff --git a/src/kibana/directives/field_name.js b/src/kibana/directives/field_name.js
index 94aa56f1e2d5..1210ed7217c9 100644
--- a/src/kibana/directives/field_name.js
+++ b/src/kibana/directives/field_name.js
@@ -16,7 +16,7 @@ define(function (require) {
           switch (fieldType)
           {
           case 'source':
-            return $('<i class="fa fa-file-text-o"></i> ');
+            return $('<i class="fa fa-file-text-o "></i> ');
           case 'string':
             return $('<i><strong>t</strong></i> ');
           case 'number':
@@ -25,6 +25,8 @@ define(function (require) {
             return $('<i class="fa fa-clock-o"></i> ');
           case 'ip':
             return $('<i class="fa fa-laptop"></i> ');
+          case 'geo_point':
+            return $('<i class="fa fa-globe"></i> ');
           case 'conflict':
             return $('<i class="fa fa-warning"></i> ');
           default:
@@ -32,7 +34,14 @@ define(function (require) {
           }
         };
 
-        var icon = typeIcon($scope.fieldType).addClass('text-muted').css({'margin-right': '5px'});
+        var icon = typeIcon($scope.fieldType)
+          .addClass('text-muted')
+          .css({
+            'margin-right': '5px',
+            'text-align': 'center',
+            'display': 'inline-block',
+            'width': '12px'
+          });
 
         $elem.text($scope.fieldName).prepend(icon);
       }