maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

make sure filter object is persistable (#87828) (#88164)

Browse source
This commit is contained in:
Joe Reuter 2021-01-13 16:06:25 +01:00 committed by GitHub
parent 7152e02ada
commit 497892e300
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/lens/public/persistence/filter_references.test.ts
View file

@ -56,6 +56,18 @@ describe('filter saved object references', () => {
`);
});
it('should remove index and value from persistable filter', () => {
const { persistableFilters } = extractFilterReferences([
{ ...filters[0], meta: { ...filters[0].meta, value: 'CN' } },
{ ...filters[1], meta: { ...filters[1].meta, value: 'US' } },
]);
expect(persistableFilters.length).toBe(2);
persistableFilters.forEach((filter) => {
expect(filter.meta.hasOwnProperty('index')).toBe(false);
expect(filter.meta.hasOwnProperty('value')).toBe(false);
});
});
it('should restore the same filter after extracting and injecting', () => {
const { persistableFilters, references } = extractFilterReferences(filters);
expect(injectFilterReferences(persistableFilters, references)).toEqual(filters);

8
x-pack/plugins/lens/public/persistence/filter_references.ts
View file

@ -22,14 +22,18 @@ export function extractFilterReferences(
type: 'index-pattern',
id: filterRow.meta.index,
});
return {
const newFilter = {
...filterRow,
meta: {
...filterRow.meta,
indexRefName: refName,
index: undefined,
},
};
// remove index because it's specified by indexRefName
delete newFilter.meta.index;
// remove value because it can't be persisted
delete newFilter.meta.value;
return newFilter;
});
return { persistableFilters, references };