maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Improve functional tests for Anomaly detection alert rule (#97998)

Browse source 
* [ML] ensureAdvancedSectionOpen for assertion

* [ML] delete alert rules after tests execution

* [ML] add isAdvancedSectionOpened
This commit is contained in:
Dima Arnautov 2021-04-22 17:16:54 +02:00 committed by GitHub
parent 2f679e6df3
commit 49cdc9066d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
x-pack/test/functional/services/ml/alerting.ts
View file

@ -8,6 +8,9 @@
import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';
import { MlCommonUI } from './common_ui';
import { ML_ALERT_TYPES } from '../../../../plugins/ml/common/constants/alerts';
import { Alert } from '../../../../plugins/alerting/common';
import { MlAnomalyDetectionAlertParams } from '../../../../plugins/ml/common/types/alerts';
export function MachineLearningAlertingProvider(
{ getService }: FtrProviderContext,
@ -17,6 +20,7 @@ export function MachineLearningAlertingProvider(
const comboBox = getService('comboBox');
const testSubjects = getService('testSubjects');
const find = getService('find');
const supertest = getService('supertest');
return {
async selectAnomalyDetectionAlertType() {
@ -103,6 +107,7 @@ export function MachineLearningAlertingProvider(
},
async assertLookbackInterval(expectedValue: string) {
await this.ensureAdvancedSectionOpen();
const actualValue = await testSubjects.getAttribute(
'mlAnomalyAlertLookbackInterval',
'value'
@ -114,6 +119,7 @@ export function MachineLearningAlertingProvider(
},
async assertTopNBuckets(expectedNumberOfBuckets: number) {
await this.ensureAdvancedSectionOpen();
const actualValue = await testSubjects.getAttribute('mlAnomalyAlertTopNBuckets', 'value');
expect(actualValue).to.eql(
expectedNumberOfBuckets,
@ -133,15 +139,31 @@ export function MachineLearningAlertingProvider(
await this.assertTopNBuckets(numberOfBuckets);
},
async isAdvancedSectionOpened() {
return await find.existsByDisplayedByCssSelector('#mlAnomalyAlertAdvancedSettings');
},
async ensureAdvancedSectionOpen() {
await retry.tryForTime(5000, async () => {
const isVisible = await find.existsByDisplayedByCssSelector(
'#mlAnomalyAlertAdvancedSettings'
);
if (!isVisible) {
if (!(await this.isAdvancedSectionOpened())) {
await testSubjects.click('mlAnomalyAlertAdvancedSettingsTrigger');
expect(await this.isAdvancedSectionOpened()).to.eql(true);
}
});
},
async cleanAnomalyDetectionRules() {
const { body: anomalyDetectionRules } = await supertest
.get(`/api/alerting/rules/_find`)
.query({ filter: `alert.attributes.alertTypeId:${ML_ALERT_TYPES.ANOMALY_DETECTION}` })
.set('kbn-xsrf', 'foo')
.expect(200);
for (const rule of anomalyDetectionRules.data as Array<
Alert<MlAnomalyDetectionAlertParams>
>) {
await supertest.delete(`/api/alerting/rule/${rule.id}`).set('kbn-xsrf', 'foo').expect(204);
}
},
};
}

1
x-pack/test/functional_with_es_ssl/apps/ml/alert_flyout.ts
View file

@ -93,6 +93,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
after(async () => {
await ml.api.cleanMlIndices();
await ml.alerting.cleanAnomalyDetectionRules();
});
describe('overview page alert flyout controls', () => {