maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix Lens heading structure (#81752)

Browse source
This commit is contained in:
Joe Reuter 2020-10-30 11:20:54 +01:00 committed by GitHub
parent b0a223ebcb
commit 512c35e70b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.tsx
View file

@ -15,6 +15,7 @@ import {
EuiPageContentHeader,
EuiFlexGroup,
EuiFlexItem,
EuiScreenReaderOnly,
} from '@elastic/eui';
import { Datasource, FramePublicAPI, Visualization } from '../../../types';
import { NativeRenderer } from '../../../native_renderer';
@ -104,18 +105,25 @@ export function WorkspacePanelWrapper({
</EuiFlexGroup>
</div>
<EuiPageContent className="lnsWorkspacePanelWrapper">
{(!emptyExpression || title) && (
{!emptyExpression || title ? (
<EuiPageContentHeader
className={classNames('lnsWorkspacePanelWrapper__pageContentHeader', {
// eslint-disable-next-line @typescript-eslint/naming-convention
'lnsWorkspacePanelWrapper__pageContentHeader--unsaved': !title,
})}
>
<span data-test-subj="lns_ChartTitle">
<h1 data-test-subj="lns_ChartTitle">
{title ||
i18n.translate('xpack.lens.chartTitle.unsaved', { defaultMessage: 'Unsaved' })}
</span>
</h1>
</EuiPageContentHeader>
) : (
<EuiScreenReaderOnly>
<h1 data-test-subj="lns_ChartTitle">
{title ||
i18n.translate('xpack.lens.chartTitle.unsaved', { defaultMessage: 'Unsaved' })}
</h1>
</EuiScreenReaderOnly>
)}
<EuiPageContentBody className="lnsWorkspacePanelWrapper__pageContentBody">
{children}