maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Bug] Fixing flash of unstyled dashboard content (#25559)

Browse source 
Fixes #25375
This commit is contained in:
Caroline Horn 2018-11-13 20:04:17 -05:00 committed by GitHub
parent 101c352221
commit 548f76e3b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/core_plugins/kibana/public/dashboard/_hacks.scss
View file

@ -24,8 +24,8 @@ dashboard-listing {
// Yes, this is a hack because bootstrap will be removed and everything must move to EUI theming
// Can't reliably remove all/any of these because of embeddables
.tab-dashboard.theme-dark {
@import './../../../../../node_modules/@elastic/eui/src/themes/k6/k6_colors_dark';
.theme-dark {
@import '@elastic/eui/src/themes/k6/k6_colors_dark';
// /src/ui/public/styles/bootstrap/scaffolding.less
a {

10
src/core_plugins/kibana/public/dashboard/_index.scss
View file

@ -16,14 +16,14 @@
/**
* 1. Don't duplicate styles in dark mode
*/
.tab-dashboard.theme-light { /* 1 */
.theme-light { /* 1 */
@import 'dashboard_app';
@import 'grid/index';
@import 'panel/index';
@import 'viewport/index';
}
// Imports outside of .tab-dashboard selector don't change between light/dark modes
// Imports outside of theme selector don't change between light/dark modes
@import 'components/index';
// Must be outside of theme selector because it lives in a portal
@ -33,7 +33,7 @@
// EUI global scope -- dark
@import '@elastic/eui/src/themes/k6/k6_colors_dark';
.tab-dashboard.theme-dark {
.theme-dark {
background-color: $euiColorEmptyShade;
@import 'dashboard_app';
@ -41,6 +41,8 @@
@import 'panel/index';
@import 'viewport/index';
// Vis imports
// Vis imports -- will have some duplicate styling
// because they will be imported via ui/public as well
// (without .theme-[] prefix)
@import 'src/ui/public/vis/map/index';
}