maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Dashboard] [Functional Tests] Unskip by value Example (#116513)

Browse source 
* Unskip dashboard by value example tests
This commit is contained in:
Devon Thomson 2021-11-09 11:43:09 -05:00 committed by GitHub
parent 32f75a47ab
commit 56bfd0e53d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
examples/embeddable_examples/public/hello_world/hello_world_embeddable.tsx
View file

@ -33,7 +33,8 @@ export class HelloWorldEmbeddable extends Embeddable {
* @param node
*/
public render(node: HTMLElement) {
node.innerHTML = '<div data-test-subj="helloWorldEmbeddable">HELLO WORLD!</div>';
node.innerHTML =
'<div data-test-subj="helloWorldEmbeddable" data-render-complete="true">HELLO WORLD!</div>';
}
/**

2
examples/embeddable_examples/public/todo/todo_component.tsx
View file

@ -41,7 +41,7 @@ function wrapSearchTerms(task: string, search?: string) {
export function TodoEmbeddableComponentInner({ input: { icon, title, task, search } }: Props) {
return (
<EuiFlexGroup gutterSize="none">
<EuiFlexGroup gutterSize="none" data-render-complete="true">
<EuiFlexItem grow={false}>
{icon ? <EuiIcon type={icon} size="l" /> : <EuiAvatar name={title || task} size="l" />}
</EuiFlexItem>

2
examples/embeddable_examples/public/todo/todo_ref_component.tsx
View file

@ -45,7 +45,7 @@ export function TodoRefEmbeddableComponentInner({
const title = savedAttributes?.title;
const task = savedAttributes?.task;
return (
<EuiFlexGroup>
<EuiFlexGroup data-render-complete="true">
<EuiFlexItem grow={false}>
{icon ? (
<EuiIcon type={icon} size="l" />

7
test/examples/embeddables/dashboard.ts
View file

@ -97,11 +97,10 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
const pieChart = getService('pieChart');
const dashboardExpect = getService('dashboardExpect');
const elasticChart = getService('elasticChart');
const PageObjects = getPageObjects(['common', 'visChart']);
const PageObjects = getPageObjects(['common', 'visChart', 'dashboard']);
const monacoEditor = getService('monacoEditor');
// FLAKY: https://github.com/elastic/kibana/issues/116414
describe.skip('dashboard container', () => {
describe('dashboard container', () => {
before(async () => {
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/dashboard/current/data');
await esArchiver.loadIfNeeded(
@ -109,6 +108,8 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
);
await PageObjects.common.navigateToApp('dashboardEmbeddableExamples');
await testSubjects.click('dashboardEmbeddableByValue');
await PageObjects.dashboard.waitForRenderComplete();
await updateInput(JSON.stringify(testDashboardInput, null, 4));
});