maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ILM] Delete index_codec option if disabled in UI (#87267)

Browse source
This commit is contained in:
Alison Goryachev 2021-01-06 08:24:41 -05:00 committed by GitHub
parent c012977eec
commit 57afacfef2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer_and_serializer.test.ts
View file

@ -172,6 +172,20 @@ describe('deserializer and serializer', () => {
expect(result.phases.warm!.actions.forcemerge).toBeUndefined();
});
it('removes the index_codec option in the forcemerge action if it is disabled in the form', () => {
formInternal.phases.warm!.actions.forcemerge = {
max_num_segments: 22,
index_codec: 'best_compression',
};
formInternal._meta.hot.bestCompression = false;
formInternal._meta.warm.bestCompression = false;
const result = serializer(formInternal);
expect(result.phases.hot!.actions.forcemerge!.index_codec).toBeUndefined();
expect(result.phases.warm!.actions.forcemerge!.index_codec).toBeUndefined();
});
it('removes the readonly action if it is disabled in hot', () => {
formInternal._meta.hot.readonlyEnabled = false;

4
x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts
View file

@ -65,6 +65,8 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => (
delete hotPhaseActions.forcemerge;
} else if (_meta.hot.bestCompression) {
hotPhaseActions.forcemerge!.index_codec = 'best_compression';
} else {
delete hotPhaseActions.forcemerge!.index_codec;
}
if (_meta.hot.bestCompression && hotPhaseActions.forcemerge) {
@ -124,6 +126,8 @@ export const createSerializer = (originalPolicy?: SerializedPolicy) => (
delete warmPhase.actions.forcemerge;
} else if (_meta.warm.bestCompression) {
warmPhase.actions.forcemerge!.index_codec = 'best_compression';
} else {
delete warmPhase.actions.forcemerge!.index_codec;
}
if (_meta.warm.readonlyEnabled) {