maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[service/remote] check env variable value (#41909)

Browse source
This commit is contained in:
Dmitry Lemeshko 2019-07-25 08:29:17 +02:00 committed by GitHub
parent 3f728334d0
commit 58f2a263d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tasks/config/karma.js
View file

@ -28,7 +28,7 @@ module.exports = function (grunt) {
if (grunt.option('browser')) {
return grunt.option('browser');
}
if (process.env.TEST_BROWSER_HEADLESS) {
if (process.env.TEST_BROWSER_HEADLESS === '1') {
return 'Chrome_Headless';
}
return 'Chrome';

9
test/functional/services/remote/webdriver.ts
View file

@ -38,7 +38,8 @@ import { preventParallelCalls } from './prevent_parallel_calls';
import { Browsers } from './browsers';
const throttleOption = process.env.TEST_THROTTLE_NETWORK;
const throttleOption: string = process.env.TEST_THROTTLE_NETWORK as string;
const headlessBrowser: string = process.env.TEST_BROWSER_HEADLESS as string;
const SECOND = 1000;
const MINUTE = 60 * SECOND;
const NO_QUEUE_COMMANDS = ['getLog', 'getStatus', 'newSession', 'quit'];
@ -73,7 +74,7 @@ async function attemptToCreateCommand(log: ToolingLog, browserType: Browsers) {
'use-fake-device-for-media-stream',
'use-fake-ui-for-media-stream',
];
if (process.env.TEST_BROWSER_HEADLESS) {
if (headlessBrowser === '1') {
// Use --disable-gpu to avoid an error from a missing Mesa library, as per
// See: https://chromium.googlesource.com/chromium/src/+/lkgr/headless/README.md
chromeOptions.push('headless', 'disable-gpu');
@ -90,7 +91,7 @@ async function attemptToCreateCommand(log: ToolingLog, browserType: Browsers) {
.build();
case 'firefox':
const firefoxOptions = new firefox.Options();
if (process.env.TEST_BROWSER_HEADLESS) {
if (headlessBrowser === '1') {
// See: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Headless_mode
firefoxOptions.addArguments('-headless');
}
@ -106,7 +107,7 @@ async function attemptToCreateCommand(log: ToolingLog, browserType: Browsers) {
const session = await buildDriverInstance();
if (throttleOption === 'true' && browserType === 'chrome') {
if (throttleOption === '1' && browserType === 'chrome') {
// Only chrome supports this option.
log.debug('NETWORK THROTTLED: 768k down, 256k up, 100ms latency.');