maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove flaky selectors: .ng-scope, .ng-binding and .ng-isolate.scope (#19688)

Browse source
This commit is contained in:
liza-mae 2018-06-07 11:17:16 -06:00 committed by GitHub
parent e5465ea7f1
commit 5ccaca45b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/functional/page_objects/discover_page.js
View file

@ -198,7 +198,7 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
getDocHeader() {
return getRemote()
.findByCssSelector('thead.ng-isolate-scope > tr:nth-child(1)')
.findByCssSelector('thead > tr:nth-child(1)')
.getVisibleText();
}

2
test/functional/page_objects/header_page.js
View file

@ -225,7 +225,7 @@ export function HeaderPageProvider({ getService, getPageObjects }) {
async getToastMessage(findTimeout = defaultFindTimeout) {
const toastMessage =
await find.displayedByCssSelector('kbn-truncated.toast-message.ng-isolate-scope', findTimeout);
await find.displayedByCssSelector('kbn-truncated.toast-message', findTimeout);
const messageText = await toastMessage.getVisibleText();
log.debug(`getToastMessage: ${messageText}`);
return messageText;

2
test/functional/page_objects/monitoring_page.js
View file

@ -39,7 +39,7 @@ export function MonitoringPageProvider({ getService }) {
getToasterContents() {
return getRemote()
.findByCssSelector('div.toaster-container.ng-isolate-scope')
.findByCssSelector('div.toaster-container')
.getVisibleText();
}

12
test/functional/page_objects/visualize_page.js
View file

@ -128,7 +128,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
}
async getChartTypeCount() {
const tags = await find.allByCssSelector('a.wizard-vis-type.ng-scope');
const tags = await find.allByCssSelector('a.wizard-vis-type');
return tags.length;
}
@ -399,7 +399,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
// clickBucket(bucketType) 'X-Axis', 'Split Area', 'Split Chart'
async clickBucket(bucketName) {
const chartTypes = await retry.try(
async () => await find.allByCssSelector('li.list-group-item.list-group-menu-item.ng-binding.ng-scope'));
async () => await find.allByCssSelector('li.list-group-item.list-group-menu-item'));
log.debug('found bucket types ' + chartTypes.length);
async function getChartType(chart) {
@ -447,7 +447,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
const aggItem = await find.byCssSelector(`[data-test-subj="${agg}"]`);
await aggItem.click();
const fieldSelect = await find
.byCssSelector(`#visAggEditorParams${index} > [agg-param="agg.type.params[0]"] > div > div > div.ui-select-match.ng-scope > span`);
.byCssSelector(`#visAggEditorParams${index} > [agg-param="agg.type.params[0]"] > div > div > div.ui-select-match > span`);
// open field selection list
await fieldSelect.click();
// select our field
@ -515,7 +515,7 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
async orderBy(fieldValue) {
await find.clickByCssSelector(
'select.form-control.ng-pristine.ng-valid.ng-untouched.ng-valid-required[ng-model="agg.params.orderBy"]'
+ `option.ng-binding.ng-scope:contains("${fieldValue}")`);
+ `option:contains("${fieldValue}")`);
}
async selectOrderBy(fieldValue) {
@ -822,12 +822,12 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
}
async getMarkdownData() {
const markdown = await retry.try(async () => find.byCssSelector('visualize.ng-isolate-scope'));
const markdown = await retry.try(async () => find.byCssSelector('visualize'));
return await markdown.getVisibleText();
}
async clickColumns() {
await find.clickByCssSelector('div.schemaEditors.ng-scope > div > div > button:nth-child(2)');
await find.clickByCssSelector('div.schemaEditors > div > div > button:nth-child(2)');
}
async waitForVisualization() {