remove setTimeoue for state change (#45853) (#45893)

This commit is contained in:
Angela Chuang 2019-09-18 13:12:22 +01:00 committed by GitHub
parent 00df5d2388
commit 5ddc355198
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 24 deletions

View file

@ -102,7 +102,7 @@
"dependencies": {
"@babel/core": "^7.5.5",
"@babel/register": "^7.5.5",
"@elastic/charts": "^11.1.1",
"@elastic/charts": "^12.0.2",
"@elastic/datemath": "5.0.2",
"@elastic/eui": "14.0.0",
"@elastic/filesaver": "1.1.2",

View file

@ -130,14 +130,7 @@ const HostDetailsComponent = React.memo<HostDetailsComponentProps>(
setQuery={setQuery}
to={to}
narrowDateRange={(min: number, max: number) => {
/**
* Using setTimeout here because of this issue:
* https://github.com/elastic/elastic-charts/issues/360
* Need to remove the setTimeout here after this issue is fixed.
* */
setTimeout(() => {
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}, 500);
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}}
/>
)}

View file

@ -101,14 +101,7 @@ const HostsComponent = React.memo<HostsComponentProps>(
setQuery={setQuery}
to={to}
narrowDateRange={(min: number, max: number) => {
/**
* Using setTimeout here because of this issue:
* https://github.com/elastic/elastic-charts/issues/360
* Need to remove the setTimeout here after this issue is fixed.
* */
setTimeout(() => {
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}, 500);
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}}
/>
)}

View file

@ -126,9 +126,7 @@ const NetworkComponent = React.memo<NetworkComponentProps>(
from={from}
to={to}
narrowDateRange={(min: number, max: number) => {
setTimeout(() => {
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}, 500);
setAbsoluteRangeDatePicker({ id: 'global', from: min, to: max });
}}
/>
)}

View file

@ -902,10 +902,10 @@
debug "^3.1.0"
lodash.once "^4.1.1"
"@elastic/charts@^11.1.1":
version "11.1.1"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-11.1.1.tgz#32e1b18ec7ede9e3d62c3375284ad31d778017e2"
integrity sha512-zay5cQ39XzoKe0cabL/GCI2W1bjqatT20K/u7ZdHFa+GpazUd1/zjOpsLsKlq31Rr5yWXbc2M2iC4ZUp8n8crg==
"@elastic/charts@^12.0.2":
version "12.0.2"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-12.0.2.tgz#576fafccd9e9f6ca751b6e846be3a5c954e8865b"
integrity sha512-BxdJVXUkYE11X+n5QWfu6ntDCm6wbkvLRNWrJG30pgGv9QEDhEbraQ8ql9Vx1454EuEjgXP6xOM0X+3rCO4Nqw==
dependencies:
"@types/d3-shape" "^1.3.1"
"@types/luxon" "^1.11.1"