maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

chore: add modifications to staging automatically after eslint fix (#113443)

Browse source 
After precommit hook runs with --fix flag changes are not added to staging. However it also does not
validate staging area since eslint is only looking for last changes on file not staging area this
results fellows to commit with linting errors which fails in CI. This commit resolves this issue by
adding fixed files right after linting to staging area.

Closes #52722

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Baturalp Gurdin 2021-10-01 13:51:58 +02:00 committed by GitHub
parent a4903aca4d
commit 5df9d41dbc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/dev/run_precommit_hook.js
View file

@ -6,6 +6,9 @@
* Side Public License, v 1.
*/
import SimpleGit from 'simple-git/promise';
import { REPO_ROOT } from '@kbn/utils';
import { run, combineErrors, createFlagError, createFailError } from '@kbn/dev-utils';
import * as Eslint from './eslint';
import * as Stylelint from './stylelint';
@ -48,6 +51,11 @@ run(
await Linter.lintFiles(log, filesToLint, {
fix: flags.fix,
});
if (flags.fix) {
const simpleGit = new SimpleGit(REPO_ROOT);
await simpleGit.add(filesToLint);
}
} catch (error) {
errors.push(error);
}