From f69f39c518e084098aa91c9033ad0678a0dfb2eb Mon Sep 17 00:00:00 2001 From: spalger Date: Thu, 5 Nov 2015 13:23:58 -0600 Subject: [PATCH 1/2] [chrome] let users call setVisible() before angular bootstrap --- src/ui/public/chrome/api/angular.js | 2 +- src/ui/public/chrome/api/controls.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ui/public/chrome/api/angular.js b/src/ui/public/chrome/api/angular.js index 91c35fb591c3..db003c08a171 100644 --- a/src/ui/public/chrome/api/angular.js +++ b/src/ui/public/chrome/api/angular.js @@ -45,7 +45,7 @@ module.exports = function (chrome, internals) { controller: function ($scope, $rootScope, $location, $http) { // are we showing the embedded version of the chrome? - chrome.setVisible(!Boolean($location.search().embed)); + internals.setVisibleDefault(!$location.search().embed); // listen for route changes, propogate to tabs var onRouteChange = function () { diff --git a/src/ui/public/chrome/api/controls.js b/src/ui/public/chrome/api/controls.js index a8652ed59bf4..116e37411cff 100644 --- a/src/ui/public/chrome/api/controls.js +++ b/src/ui/public/chrome/api/controls.js @@ -10,6 +10,9 @@ module.exports = function (chrome, internals) { * determines if the Kibana chrome should be displayed */ + var def = true; + internals.setVisibleDefault = (_def) => def = Boolean(_def); + /** * @param {boolean} display - should the chrome be displayed * @return {chrome} @@ -23,7 +26,7 @@ module.exports = function (chrome, internals) { * @return {boolean} - display state of the chrome */ chrome.getVisible = function () { - if (_.isUndefined(internals.visible)) return true; + if (_.isUndefined(internals.visible)) return def; return internals.visible; }; }; From c1d3598d92dff6f212829d8e26a5e882abfaa2ac Mon Sep 17 00:00:00 2001 From: spalger Date: Thu, 5 Nov 2015 13:42:47 -0600 Subject: [PATCH 2/2] =?UTF-8?q?[chrome]=C2=A0allow=20changing=20visibility?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/ui/public/chrome/chrome.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/public/chrome/chrome.html b/src/ui/public/chrome/chrome.html index 39c2b259c820..4105363a942e 100644 --- a/src/ui/public/chrome/chrome.html +++ b/src/ui/public/chrome/chrome.html @@ -2,7 +2,7 @@