maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Single Metric Viewer: Fix annnotations refresh. (#56107)

Browse source 
When creating/editing/deleting an annotation, the Single Metric Viewer page wouldn't update with the applied changes. This fixes it by tracking the change in the outer component with lastRefresh/previousRefresh and making it a condition in contextChartSelected() to trigger an update after a refresh.
This commit is contained in:
Walter Rafelsberger 2020-01-28 16:07:31 +01:00 committed by GitHub
parent a1ccb29731
commit 5ecd34afda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
x-pack/legacy/plugins/ml/public/application/routing/routes/timeseriesexplorer.tsx
View file

@ -89,6 +89,7 @@ export const TimeSeriesExplorerUrlStateManager: FC<TimeSeriesExplorerUrlStateMan
const [appState, setAppState] = useUrlState('_a');
const [globalState, setGlobalState] = useUrlState('_g');
const [lastRefresh, setLastRefresh] = useState(0);
const previousRefresh = usePrevious(lastRefresh);
const [selectedJobId, setSelectedJobId] = useState<string>();
const refresh = useRefresh();
@ -295,6 +296,7 @@ export const TimeSeriesExplorerUrlStateManager: FC<TimeSeriesExplorerUrlStateMan
bounds,
dateFormatTz,
lastRefresh,
previousRefresh,
selectedJobId,
selectedDetectorIndex,
selectedEntities,

10
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
View file

@ -161,6 +161,7 @@ export class TimeSeriesExplorer extends React.Component {
bounds: PropTypes.object.isRequired,
dateFormatTz: PropTypes.string.isRequired,
lastRefresh: PropTypes.number.isRequired,
previousRefresh: PropTypes.number.isRequired,
selectedJobId: PropTypes.string.isRequired,
selectedDetectorIndex: PropTypes.number,
selectedEntities: PropTypes.object,
@ -319,7 +320,11 @@ export class TimeSeriesExplorer extends React.Component {
to: selection.to.toISOString(),
};
if (isEqual(this.props.zoom, zoomState) && this.state.focusChartData !== undefined) {
if (
isEqual(this.props.zoom, zoomState) &&
this.state.focusChartData !== undefined &&
this.props.previousRefresh === this.props.lastRefresh
) {
return;
}
@ -1089,13 +1094,12 @@ export class TimeSeriesExplorer extends React.Component {
this.previousShowAnnotations === showAnnotations &&
this.previousShowForecast === showForecast &&
this.previousShowModelBounds === showModelBounds &&
this.previousLastRefresh === lastRefresh
this.props.previousRefresh === lastRefresh
) {
renderFocusChartOnly = false;
}
this.previousChartProps = chartProps;
this.previousLastRefresh = lastRefresh;
this.previousShowAnnotations = showAnnotations;
this.previousShowForecast = showForecast;
this.previousShowModelBounds = showModelBounds;