maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Discover] Replace font-awesome data table filter in/out icons with EUI (#79622)

Browse source
This commit is contained in:
Matthias Wilhelm 2020-10-07 09:46:46 +02:00 committed by GitHub
parent 019e2ad9a5
commit 603adab5e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/discover/public/application/angular/doc_table/components/table_row.ts
View file

@ -109,7 +109,7 @@ export function createTableRowDirective($compile: ng.ICompileService) {
});
$scope.inlineFilter = function inlineFilter($event: any, type: string) {
const column = $($event.target).data().column;
const column = $($event.currentTarget).data().column;
const field = $scope.indexPattern.fields.getByName(column);
$scope.filter(field, $scope.flattenedRow[column], type);
};

8
src/plugins/discover/public/application/angular/doc_table/components/table_row/cell.html
View file

@ -14,24 +14,24 @@ if (timefield) {
<% if (filterable) { %>
<button
ng-click="inlineFilter($event, '+')"
class="fa fa-search-plus kbnDocTableRowFilterButton"
class="kbnDocTableRowFilterButton"
data-column="<%- column %>"
tooltip-append-to-body="1"
data-test-subj="docTableCellFilter"
tooltip="{{ ::'discover.docTable.tableRow.filterForValueButtonTooltip' | i18n: {defaultMessage: 'Filter for value'} }}"
tooltip-placement="bottom"
aria-label="{{ ::'discover.docTable.tableRow.filterForValueButtonAriaLabel' | i18n: {defaultMessage: 'Filter for value'} }}"
></button>
><icon type="'plusInCircle'" size="'s'" color="'primary'"></icon></button>
<button
ng-click="inlineFilter($event, '-')"
class="fa fa-search-minus kbnDocTableRowFilterButton"
class="kbnDocTableRowFilterButton"
data-column="<%- column %>"
data-test-subj="docTableCellFilterNegate"
tooltip="{{ ::'discover.docTable.tableRow.filterOutValueButtonTooltip' | i18n: {defaultMessage: 'Filter out value'} }}"
aria-label="{{ ::'discover.docTable.tableRow.filterOutValueButtonAriaLabel' | i18n: {defaultMessage: 'Filter out value'} }}"
tooltip-append-to-body="1"
tooltip-placement="bottom"
></button>
><icon type="'minusInCircle'" size="'s'" color="'primary'"></icon></button>
<% } %>
</span>
</td>