From 644e08b94fed30cdc593aa5255247e45b4864d4f Mon Sep 17 00:00:00 2001 From: Devon Thomson Date: Mon, 15 Mar 2021 12:51:59 -0400 Subject: [PATCH] [Time to Visualize] Fix Unsaved Changes Badge Appearing After Save & Return (#94529) * fixed unsaved changes out of sync after save and return --- .../public/application/hooks/use_dashboard_container.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/plugins/dashboard/public/application/hooks/use_dashboard_container.ts b/src/plugins/dashboard/public/application/hooks/use_dashboard_container.ts index 109380ed0d89..0be29f67a949 100644 --- a/src/plugins/dashboard/public/application/hooks/use_dashboard_container.ts +++ b/src/plugins/dashboard/public/application/hooks/use_dashboard_container.ts @@ -80,11 +80,7 @@ export const useDashboardContainer = ({ searchSession.restore(searchSessionIdFromURL); } - // when dashboard state manager initially loads, determine whether or not there are unsaved changes const incomingEmbeddable = getIncomingEmbeddable(true); - setUnsavedChanges?.( - Boolean(incomingEmbeddable) || dashboardStateManager.hasUnsavedPanelState() - ); let canceled = false; let pendingContainer: DashboardContainer | ErrorEmbeddable | null | undefined; @@ -137,6 +133,7 @@ export const useDashboardContainer = ({ ); } setDashboardContainer(pendingContainer); + setUnsavedChanges?.(dashboardStateManager.getIsDirty(data.query.timefilter.timefilter)); })(); return () => { canceled = true; @@ -151,6 +148,7 @@ export const useDashboardContainer = ({ setDashboardContainer(null); }; }, [ + data.query.timefilter.timefilter, dashboardCapabilities, dashboardStateManager, getIncomingEmbeddable,