maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[7.x] [Lens] Better disabled messages for Value labels popup (#85592) (#85949)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Marco Liberati 2020-12-16 09:56:37 +01:00 committed by GitHub
parent 91dacb606f
commit 64ab3957f7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx
View file

@ -154,6 +154,28 @@ export function LayerContextMenu(props: VisualizationLayerWidgetProps<State>) {
);
}
function getValueLabelDisableReason({
isAreaPercentage,
isHistogramSeries,
}: {
isAreaPercentage: boolean;
isHistogramSeries: boolean;
}): string {
if (isHistogramSeries) {
return i18n.translate('xpack.lens.xyChart.valuesHistogramDisabledHelpText', {
defaultMessage: 'This setting cannot be changed on histograms.',
});
}
if (isAreaPercentage) {
return i18n.translate('xpack.lens.xyChart.valuesPercentageDisabledHelpText', {
defaultMessage: 'This setting cannot be changed on percentage area charts.',
});
}
return i18n.translate('xpack.lens.xyChart.valuesStackedDisabledHelpText', {
defaultMessage: 'This setting cannot be changed on stacked or percentage bar charts',
});
}
export function XyToolbar(props: VisualizationToolbarProps<State>) {
const { state, setState, frame } = props;
@ -246,20 +268,17 @@ export function XyToolbar(props: VisualizationToolbarProps<State>) {
const isValueLabelsEnabled = !hasNonBarSeries && hasBarNotStacked && !isHistogramSeries;
const isFittingEnabled = hasNonBarSeries;
const valueLabelsDisabledReason = getValueLabelDisableReason({
isAreaPercentage,
isHistogramSeries,
});
return (
<EuiFlexGroup gutterSize="m" justifyContent="spaceBetween">
<EuiFlexItem>
<EuiFlexGroup gutterSize="none" responsive={false}>
<TooltipWrapper
tooltipContent={
isAreaPercentage
? i18n.translate('xpack.lens.xyChart.valuesPercentageDisabledHelpText', {
defaultMessage: 'This setting cannot be changed on percentage area charts.',
})
: i18n.translate('xpack.lens.xyChart.valuesStackedDisabledHelpText', {
defaultMessage: 'This setting cannot be changed on histograms.',
})
}
tooltipContent={valueLabelsDisabledReason}
condition={!isValueLabelsEnabled && !isFittingEnabled}
>
<ToolbarPopover