maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove explicit close button (#20044)

Browse source
This commit is contained in:
Shaunak Kashyap 2018-06-19 23:43:24 +05:30 committed by GitHub
parent 58257c2734
commit 64d28b955b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 85 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/views/__test__/__snapshots__/detail_drawer.test.js.snap
View file

@ -41,18 +41,6 @@ exports[`DetailDrawer component If vertices shows basic info and no stats for if
</h2>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
component="div"
grow={false}
>
<EuiButtonIcon
aria-label="Close"
color="text"
iconType="cross"
onClick={[MockFunction]}
type="button"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>
@ -121,18 +109,6 @@ exports[`DetailDrawer component Plugin vertices Plugin does not have explicit ID
</h2>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
component="div"
grow={false}
>
<EuiButtonIcon
aria-label="Close"
color="text"
iconType="cross"
onClick={[MockFunction]}
type="button"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>
@ -423,18 +399,6 @@ exports[`DetailDrawer component Plugin vertices Plugin has explicit ID shows bas
</h2>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
component="div"
grow={false}
>
<EuiButtonIcon
aria-label="Close"
color="text"
iconType="cross"
onClick={[MockFunction]}
type="button"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>
@ -721,18 +685,6 @@ exports[`DetailDrawer component Queue vertices shows basic info and no stats for
</h2>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
component="div"
grow={false}
>
<EuiButtonIcon
aria-label="Close"
color="text"
iconType="cross"
onClick={[MockFunction]}
type="button"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>
@ -789,18 +741,6 @@ exports[`DetailDrawer component shows vertex title 1`] = `
<h2 />
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem
component="div"
grow={false}
>
<EuiButtonIcon
aria-label="Close"
color="text"
iconType="cross"
onClick={[MockFunction]}
type="button"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>

16
x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/views/__test__/detail_drawer.test.js
View file

@ -32,22 +32,6 @@ describe('DetailDrawer component', () => {
expect(renderedComponent).toMatchSnapshot();
});
test('calls onHide function when close button is clicked', () => {
const vertex = {
title: 'grok'
};
const component = (
<DetailDrawer
vertex={vertex}
onHide={onHide}
/>
);
const renderedComponent = shallow(component);
renderedComponent.find('EuiButtonIcon').simulate('click');
expect(onHide.mock.calls.length).toEqual(1);
});
describe('Plugin vertices', () => {
describe('Plugin has explicit ID', () => {
test('shows basic info and stats for plugin, including explicit ID', () => {

9
x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/views/detail_drawer.js
View file

@ -19,7 +19,6 @@ import {
EuiCodeBlock,
EuiFlexGroup,
EuiFlexItem,
EuiButtonIcon,
EuiSpacer,
EuiBadge,
} from '@elastic/eui';
@ -280,14 +279,6 @@ export function DetailDrawer({ vertex, onHide, timeseriesTooltipXValueFormatter
<h2>{ renderTitle(vertex) }</h2>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
onClick={onHide}
iconType="cross"
color="text"
aria-label="Close"
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutHeader>
<EuiFlyoutBody>