From 6ded39ee7b45e6582dfc42d0114c6f15551069d6 Mon Sep 17 00:00:00 2001
From: Maryia Lapata <mary.lopato@gmail.com>
Date: Wed, 19 Sep 2018 18:32:00 +0300
Subject: [PATCH] Translate markdown_vis (#23186) (#23320)

* Translate markdown_vis

* Remove space

* Update ids

* Fix a typo
---
 .i18nrc.json                                  |  1 +
 .../markdown_vis/public/markdown_vis.js       |  6 ++--
 .../public/markdown_vis_params.html           | 33 ++++++++++++++++---
 3 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/.i18nrc.json b/.i18nrc.json
index d53285671b76..30301d72f36e 100644
--- a/.i18nrc.json
+++ b/.i18nrc.json
@@ -3,6 +3,7 @@
     "common.ui": "src/ui",
     "inputControl":"src/core_plugins/input_control_vis",
     "kbn": "src/core_plugins/kibana",
+    "markdownVis": "src/core_plugins/markdown_vis",
     "statusPage": "src/core_plugins/status_page",
     "xpack.idxMgmt": "x-pack/plugins/index_management"
   },
diff --git a/src/core_plugins/markdown_vis/public/markdown_vis.js b/src/core_plugins/markdown_vis/public/markdown_vis.js
index fa606c04cb9f..239832cd778a 100644
--- a/src/core_plugins/markdown_vis/public/markdown_vis.js
+++ b/src/core_plugins/markdown_vis/public/markdown_vis.js
@@ -31,17 +31,17 @@ import { DefaultEditorSize } from 'ui/vis/editor_size';
 // register the provider with the visTypes registry so that other know it exists
 VisTypesRegistryProvider.register(MarkdownVisProvider);
 
-function MarkdownVisProvider(Private) {
+function MarkdownVisProvider(Private, i18n) {
   const VisFactory = Private(VisFactoryProvider);
 
   // return the visType object, which kibana will use to display and configure new
   // Vis object of this type.
   return VisFactory.createReactVisualization({
     name: 'markdown',
-    title: 'Markdown',
+    title: i18n('markdownVis.markdownTitle', { defaultMessage: 'Markdown' }),
     isAccessible: true,
     icon: 'visText',
-    description: 'Create a document using markdown syntax',
+    description: i18n('markdownVis.markdownDescription', { defaultMessage: 'Create a document using markdown syntax' }),
     category: CATEGORY.OTHER,
     visConfig: {
       component: MarkdownVisWrapper,
diff --git a/src/core_plugins/markdown_vis/public/markdown_vis_params.html b/src/core_plugins/markdown_vis/public/markdown_vis_params.html
index cbeedb0bfd50..dae00442726b 100644
--- a/src/core_plugins/markdown_vis/public/markdown_vis_params.html
+++ b/src/core_plugins/markdown_vis/public/markdown_vis_params.html
@@ -1,20 +1,43 @@
 <div class="kuiSideBarSection">
   <div class="markdown-vis-options form-group">
     <div>
-      <label for="markdownVisInput">Markdown</label>
-      <small class="pull-right"><a target="_window" href="https://help.github.com/articles/github-flavored-markdown/">Help <i aria-hidden="true" class="fa fa-link"></i></a></small>
+      <label
+        for="markdownVisInput"
+        i18n-id="markdownVis.params.markdownLabel"
+        i18n-default-message="Markdown"
+      >
+      </label>
+      <small class="pull-right">
+        <a target="_window" href="https://help.github.com/articles/github-flavored-markdown/">
+          <span
+            i18n-id="markdownVis.params.helpLinkLabel"
+            i18n-default-message="Help"
+          >
+          </span>
+          <i aria-hidden="true" class="fa fa-link"></i>
+        </a>
+      </small>
     </div>
     <div class="kuiSideBarFormRow">
       <label class="kuiSideBarFormRow__label" for="markdownVisFontSize">
-        Font Size (<span ng-bind="editorState.params.fontSize"></span>pt)
+        <span
+          i18n-id="markdownVis.params.fontSizeLabel"
+          i18n-default-message="Font Size ({fontSize}pt)"
+          i18n-values="{ fontSize: editorState.params.fontSize }"
+        >
+        </span>
       </label>
       <div class="kuiSideBarFormRow__control">
         <input id="markdownVisFontSize" type="range" ng-model="editorState.params.fontSize" class="form-control" min="8" max="36" />
       </div>
     </div>
     <div class="kuiSideBarFormRow">
-      <label class="kuiSideBarFormRow__label" for="markdownVisOpenLinksInNewTab">
-        Open links in new tab
+      <label
+        class="kuiSideBarFormRow__label"
+        for="markdownVisOpenLinksInNewTab"
+        i18n-id="markdownVis.params.openLinksLabel"
+        i18n-default-message="Open links in new tab"
+      >
       </label>
       <div class="kuiSideBarFormRow__control">
         <input