Move tests from factories to their correct locations (#33851)
This commit is contained in:
Liza Katz
GitHub
parent
508acd3065
commit
751524b673
|
|
@ -17,25 +17,236 @@
|
|||
* under the License.
|
||||
*/
|
||||
|
||||
import _ from 'lodash';
|
||||
import sinon from 'sinon';
|
||||
import ngMock from 'ng_mock';
|
||||
import { EventsProvider } from '../events';
|
||||
import expect from '@kbn/expect';
|
||||
import '../private';
|
||||
import { createLegacyClass } from '../utils/legacy_class';
|
||||
|
||||
describe('events', function () {
|
||||
describe('Events', function () {
|
||||
require('test_utils/no_digest_promises').activateForSuite();
|
||||
|
||||
let events;
|
||||
let Events;
|
||||
let Promise;
|
||||
let eventsInstance;
|
||||
|
||||
beforeEach(ngMock.module('kibana'));
|
||||
beforeEach(ngMock.inject(function (Private) {
|
||||
const Events = Private(EventsProvider);
|
||||
events = new Events();
|
||||
beforeEach(ngMock.inject(function ($injector, Private) {
|
||||
Promise = $injector.get('Promise');
|
||||
Events = Private(EventsProvider);
|
||||
eventsInstance = new Events();
|
||||
}));
|
||||
|
||||
it('should handle on events', function () {
|
||||
const obj = new Events();
|
||||
const prom = obj.on('test', function (message) {
|
||||
expect(message).to.equal('Hello World');
|
||||
});
|
||||
|
||||
obj.emit('test', 'Hello World');
|
||||
|
||||
return prom;
|
||||
});
|
||||
|
||||
it('should work with inherited objects', function () {
|
||||
createLegacyClass(MyEventedObject).inherits(Events);
|
||||
function MyEventedObject() {
|
||||
MyEventedObject.Super.call(this);
|
||||
}
|
||||
const obj = new MyEventedObject();
|
||||
|
||||
const prom = obj.on('test', function (message) {
|
||||
expect(message).to.equal('Hello World');
|
||||
});
|
||||
|
||||
obj.emit('test', 'Hello World');
|
||||
|
||||
return prom;
|
||||
});
|
||||
|
||||
it('should clear events when off is called', function () {
|
||||
const obj = new Events();
|
||||
obj.on('test', _.noop);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
expect(obj._listeners.test).to.have.length(1);
|
||||
obj.off();
|
||||
expect(obj._listeners).to.not.have.property('test');
|
||||
});
|
||||
|
||||
it('should clear a specific handler when off is called for an event', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
const handler2 = sinon.stub();
|
||||
obj.on('test', handler1);
|
||||
obj.on('test', handler2);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
obj.off('test', handler1);
|
||||
|
||||
return obj.emit('test', 'Hello World')
|
||||
.then(function () {
|
||||
sinon.assert.calledOnce(handler2);
|
||||
sinon.assert.notCalled(handler1);
|
||||
});
|
||||
});
|
||||
|
||||
it('should clear a all handlers when off is called for an event', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
obj.on('test', handler1);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
obj.off('test');
|
||||
expect(obj._listeners).to.not.have.property('test');
|
||||
|
||||
return obj.emit('test', 'Hello World')
|
||||
.then(function () {
|
||||
sinon.assert.notCalled(handler1);
|
||||
});
|
||||
});
|
||||
|
||||
it('should handle multiple identical emits in the same tick', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
|
||||
obj.on('test', handler1);
|
||||
const emits = [
|
||||
obj.emit('test', 'one'),
|
||||
obj.emit('test', 'two'),
|
||||
obj.emit('test', 'three')
|
||||
];
|
||||
|
||||
return Promise
|
||||
.all(emits)
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length);
|
||||
expect(handler1.getCall(0).calledWith('one')).to.be(true);
|
||||
expect(handler1.getCall(1).calledWith('two')).to.be(true);
|
||||
expect(handler1.getCall(2).calledWith('three')).to.be(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should handle emits from the handler', function () {
|
||||
const obj = new Events();
|
||||
const secondEmit = Promise.defer();
|
||||
const handler1 = sinon.spy(function () {
|
||||
if (handler1.calledTwice) {
|
||||
return;
|
||||
}
|
||||
obj.emit('test').then(_.bindKey(secondEmit, 'resolve'));
|
||||
});
|
||||
|
||||
obj.on('test', handler1);
|
||||
|
||||
return Promise
|
||||
.all([
|
||||
obj.emit('test'),
|
||||
secondEmit.promise
|
||||
])
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(2);
|
||||
});
|
||||
});
|
||||
|
||||
it('should only emit to handlers registered before emit is called', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
const handler2 = sinon.stub();
|
||||
|
||||
obj.on('test', handler1);
|
||||
const emits = [
|
||||
obj.emit('test', 'one'),
|
||||
obj.emit('test', 'two'),
|
||||
obj.emit('test', 'three')
|
||||
];
|
||||
|
||||
|
||||
return Promise.all(emits).then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length);
|
||||
|
||||
obj.on('test', handler2);
|
||||
|
||||
const emits2 = [
|
||||
obj.emit('test', 'four'),
|
||||
obj.emit('test', 'five'),
|
||||
obj.emit('test', 'six')
|
||||
];
|
||||
|
||||
return Promise.all(emits2)
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length + emits2.length);
|
||||
expect(handler2.callCount).to.be(emits2.length);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
it('should pass multiple arguments from the emitter', function () {
|
||||
const obj = new Events();
|
||||
const handler = sinon.stub();
|
||||
const payload = [
|
||||
'one',
|
||||
{ hello: 'tests' },
|
||||
null
|
||||
];
|
||||
|
||||
obj.on('test', handler);
|
||||
|
||||
return obj.emit('test', payload[0], payload[1], payload[2])
|
||||
.then(function () {
|
||||
expect(handler.callCount).to.be(1);
|
||||
expect(handler.calledWithExactly(payload[0], payload[1], payload[2])).to.be(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should preserve the scope of the handler', function () {
|
||||
const obj = new Events();
|
||||
const expected = 'some value';
|
||||
let testValue;
|
||||
|
||||
function handler() {
|
||||
testValue = this.getVal();
|
||||
}
|
||||
handler.getVal = _.constant(expected);
|
||||
|
||||
obj.on('test', handler);
|
||||
return obj.emit('test')
|
||||
.then(function () {
|
||||
expect(testValue).to.equal(expected);
|
||||
});
|
||||
});
|
||||
|
||||
it('should always emit in the same order', function () {
|
||||
const handler = sinon.stub();
|
||||
|
||||
const obj = new Events();
|
||||
obj.on('block', _.partial(handler, 'block'));
|
||||
obj.on('last', _.partial(handler, 'last'));
|
||||
|
||||
return Promise
|
||||
.all([
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('last')
|
||||
])
|
||||
.then(function () {
|
||||
expect(handler.callCount).to.be(10);
|
||||
handler.args.forEach(function (args, i) {
|
||||
expect(args[0]).to.be(i < 9 ? 'block' : 'last');
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
it('calls emitted handlers asynchronously', (done) => {
|
||||
const listenerStub = sinon.stub();
|
||||
events.on('test', listenerStub);
|
||||
events.emit('test');
|
||||
eventsInstance.on('test', listenerStub);
|
||||
eventsInstance.emit('test');
|
||||
sinon.assert.notCalled(listenerStub);
|
||||
|
||||
setTimeout(() => {
|
||||
|
|
@ -46,11 +257,11 @@ describe('events', function () {
|
|||
|
||||
it('calling off after an emit that has not yet triggered the handler, will not call the handler', (done) => {
|
||||
const listenerStub = sinon.stub();
|
||||
events.on('test', listenerStub);
|
||||
events.emit('test');
|
||||
eventsInstance.on('test', listenerStub);
|
||||
eventsInstance.emit('test');
|
||||
// It's called asynchronously so it shouldn't be called yet.
|
||||
sinon.assert.notCalled(listenerStub);
|
||||
events.off('test', listenerStub);
|
||||
eventsInstance.off('test', listenerStub);
|
||||
|
||||
setTimeout(() => {
|
||||
sinon.assert.notCalled(listenerStub);
|
||||
|
|
|
|||
|
|
@ -1,244 +0,0 @@
|
|||
/*
|
||||
* Licensed to Elasticsearch B.V. under one or more contributor
|
||||
* license agreements. See the NOTICE file distributed with
|
||||
* this work for additional information regarding copyright
|
||||
* ownership. Elasticsearch B.V. licenses this file to you under
|
||||
* the Apache License, Version 2.0 (the "License"); you may
|
||||
* not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
|
||||
|
||||
import _ from 'lodash';
|
||||
import sinon from 'sinon';
|
||||
import expect from '@kbn/expect';
|
||||
import ngMock from 'ng_mock';
|
||||
import '../../private';
|
||||
import { EventsProvider } from '../../events';
|
||||
import { createLegacyClass } from '../../utils/legacy_class';
|
||||
|
||||
describe('Events', function () {
|
||||
require('test_utils/no_digest_promises').activateForSuite();
|
||||
|
||||
let Events;
|
||||
let Promise;
|
||||
|
||||
beforeEach(ngMock.module('kibana'));
|
||||
beforeEach(ngMock.inject(function ($injector, Private) {
|
||||
Promise = $injector.get('Promise');
|
||||
Events = Private(EventsProvider);
|
||||
}));
|
||||
|
||||
it('should handle on events', function () {
|
||||
const obj = new Events();
|
||||
const prom = obj.on('test', function (message) {
|
||||
expect(message).to.equal('Hello World');
|
||||
});
|
||||
|
||||
obj.emit('test', 'Hello World');
|
||||
|
||||
return prom;
|
||||
});
|
||||
|
||||
it('should work with inherited objects', function () {
|
||||
createLegacyClass(MyEventedObject).inherits(Events);
|
||||
function MyEventedObject() {
|
||||
MyEventedObject.Super.call(this);
|
||||
}
|
||||
const obj = new MyEventedObject();
|
||||
|
||||
const prom = obj.on('test', function (message) {
|
||||
expect(message).to.equal('Hello World');
|
||||
});
|
||||
|
||||
obj.emit('test', 'Hello World');
|
||||
|
||||
return prom;
|
||||
});
|
||||
|
||||
it('should clear events when off is called', function () {
|
||||
const obj = new Events();
|
||||
obj.on('test', _.noop);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
expect(obj._listeners.test).to.have.length(1);
|
||||
obj.off();
|
||||
expect(obj._listeners).to.not.have.property('test');
|
||||
});
|
||||
|
||||
it('should clear a specific handler when off is called for an event', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
const handler2 = sinon.stub();
|
||||
obj.on('test', handler1);
|
||||
obj.on('test', handler2);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
obj.off('test', handler1);
|
||||
|
||||
return obj.emit('test', 'Hello World')
|
||||
.then(function () {
|
||||
sinon.assert.calledOnce(handler2);
|
||||
sinon.assert.notCalled(handler1);
|
||||
});
|
||||
});
|
||||
|
||||
it('should clear a all handlers when off is called for an event', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
obj.on('test', handler1);
|
||||
expect(obj._listeners).to.have.property('test');
|
||||
obj.off('test');
|
||||
expect(obj._listeners).to.not.have.property('test');
|
||||
|
||||
return obj.emit('test', 'Hello World')
|
||||
.then(function () {
|
||||
sinon.assert.notCalled(handler1);
|
||||
});
|
||||
});
|
||||
|
||||
it('should handle multiple identical emits in the same tick', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
|
||||
obj.on('test', handler1);
|
||||
const emits = [
|
||||
obj.emit('test', 'one'),
|
||||
obj.emit('test', 'two'),
|
||||
obj.emit('test', 'three')
|
||||
];
|
||||
|
||||
return Promise
|
||||
.all(emits)
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length);
|
||||
expect(handler1.getCall(0).calledWith('one')).to.be(true);
|
||||
expect(handler1.getCall(1).calledWith('two')).to.be(true);
|
||||
expect(handler1.getCall(2).calledWith('three')).to.be(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should handle emits from the handler', function () {
|
||||
const obj = new Events();
|
||||
const secondEmit = Promise.defer();
|
||||
const handler1 = sinon.spy(function () {
|
||||
if (handler1.calledTwice) {
|
||||
return;
|
||||
}
|
||||
obj.emit('test').then(_.bindKey(secondEmit, 'resolve'));
|
||||
});
|
||||
|
||||
obj.on('test', handler1);
|
||||
|
||||
return Promise
|
||||
.all([
|
||||
obj.emit('test'),
|
||||
secondEmit.promise
|
||||
])
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(2);
|
||||
});
|
||||
});
|
||||
|
||||
it('should only emit to handlers registered before emit is called', function () {
|
||||
const obj = new Events();
|
||||
const handler1 = sinon.stub();
|
||||
const handler2 = sinon.stub();
|
||||
|
||||
obj.on('test', handler1);
|
||||
const emits = [
|
||||
obj.emit('test', 'one'),
|
||||
obj.emit('test', 'two'),
|
||||
obj.emit('test', 'three')
|
||||
];
|
||||
|
||||
|
||||
return Promise.all(emits).then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length);
|
||||
|
||||
obj.on('test', handler2);
|
||||
|
||||
const emits2 = [
|
||||
obj.emit('test', 'four'),
|
||||
obj.emit('test', 'five'),
|
||||
obj.emit('test', 'six')
|
||||
];
|
||||
|
||||
return Promise.all(emits2)
|
||||
.then(function () {
|
||||
expect(handler1.callCount).to.be(emits.length + emits2.length);
|
||||
expect(handler2.callCount).to.be(emits2.length);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
it('should pass multiple arguments from the emitter', function () {
|
||||
const obj = new Events();
|
||||
const handler = sinon.stub();
|
||||
const payload = [
|
||||
'one',
|
||||
{ hello: 'tests' },
|
||||
null
|
||||
];
|
||||
|
||||
obj.on('test', handler);
|
||||
|
||||
return obj.emit('test', payload[0], payload[1], payload[2])
|
||||
.then(function () {
|
||||
expect(handler.callCount).to.be(1);
|
||||
expect(handler.calledWithExactly(payload[0], payload[1], payload[2])).to.be(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should preserve the scope of the handler', function () {
|
||||
const obj = new Events();
|
||||
const expected = 'some value';
|
||||
let testValue;
|
||||
|
||||
function handler() {
|
||||
testValue = this.getVal();
|
||||
}
|
||||
handler.getVal = _.constant(expected);
|
||||
|
||||
obj.on('test', handler);
|
||||
return obj.emit('test')
|
||||
.then(function () {
|
||||
expect(testValue).to.equal(expected);
|
||||
});
|
||||
});
|
||||
|
||||
it('should always emit in the same order', function () {
|
||||
const handler = sinon.stub();
|
||||
|
||||
const obj = new Events();
|
||||
obj.on('block', _.partial(handler, 'block'));
|
||||
obj.on('last', _.partial(handler, 'last'));
|
||||
|
||||
return Promise
|
||||
.all([
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('block'),
|
||||
obj.emit('last')
|
||||
])
|
||||
.then(function () {
|
||||
expect(handler.callCount).to.be(10);
|
||||
handler.args.forEach(function (args, i) {
|
||||
expect(args[0]).to.be(i < 9 ? 'block' : 'last');
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
@ -21,7 +21,7 @@ import expect from '@kbn/expect';
|
|||
import ngMock from 'ng_mock';
|
||||
import '../../private';
|
||||
|
||||
import { BaseObject } from '../../utils/base_object';
|
||||
import { BaseObject } from '../base_object';
|
||||
|
||||
describe('Base Object', function () {
|
||||
beforeEach(ngMock.module('kibana'));
|
||||
Loading…
Reference in a new issue