maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Data Table] Fix visualization layout in split mode (#91799) (#92263)

Browse source 
* Fix table vis layout in split mode

* Stick pagination at the bottom

* Fix functional tests

* Fix jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Daniil 2021-02-23 11:27:20 +03:00 committed by GitHub
parent 2b47fc3a0c
commit 76ca536537
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/vis_type_table/public/components/table_visualization.scss
View file

@ -18,6 +18,10 @@
padding: $euiSizeS;
margin-bottom: $euiSizeL;
display: flex;
flex-direction: column;
flex: 1 0 0;
> h3 {
text-align: center;
}

1
src/plugins/vis_type_table/public/components/table_visualization.test.tsx
View file

@ -46,7 +46,6 @@ describe('TableVisualizationComponent', () => {
);
expect(useUiState).toHaveBeenLastCalledWith(handlers.uiState);
expect(comp.find('.tbvChart__splitColumns').exists()).toBeFalsy();
expect(comp.find('.tbvChart__split').exists()).toBeTruthy();
});
it('should render split table', () => {

14
src/plugins/vis_type_table/public/components/table_visualization.tsx
View file

@ -48,14 +48,12 @@ const TableVisualizationComponent = ({
<KibanaContextProvider services={core}>
<div className={className} data-test-subj="tbvChart">
{table ? (
<div className="tbvChart__split">
<TableVisBasic
fireEvent={handlers.event}
table={table}
visConfig={visConfig}
uiStateProps={uiStateProps}
/>
</div>
<TableVisBasic
fireEvent={handlers.event}
table={table}
visConfig={visConfig}
uiStateProps={uiStateProps}
/>
) : (
<TableVisSplit
fireEvent={handlers.event}

2
test/functional/apps/visualize/_data_table.ts
View file

@ -381,6 +381,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.visualize.clickNewSearch();
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.visEditor.clickBucket('Split table');
// split by column to make all tables rows visible
await PageObjects.visEditor.clickSplitDirection('Columns');
await PageObjects.visEditor.selectAggregation('Terms');
await PageObjects.visEditor.selectField('extension.raw');
await PageObjects.visEditor.setSize(2);