maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Update TableListView to use default savedObjects:perPage config (#43979)

Browse source 
* update table list view to use default savedObjects:perPage

* move pagination settings out of state
This commit is contained in:
Liza Katz 2019-08-29 19:58:05 +03:00 committed by GitHub
parent 7995b7edc3
commit 7b6b6862c3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/legacy/core_plugins/kibana/public/table_list_view/table_list_view.js
View file

@ -39,8 +39,9 @@ import {
EuiCallOut,
} from '@elastic/eui';
import { npStart } from 'ui/new_platform';
export const EMPTY_FILTER = '';
const PAGE_SIZE_OPTIONS = [10, 20, 50];
// saved object client does not support sorting by title because title is only mapped as analyzed
// the legacy implementation got around this by pulling `listingLimit` items and doing client side sorting
@ -52,6 +53,12 @@ class TableListViewUi extends React.Component {
constructor(props) {
super(props);
const initialPageSize = npStart.core.uiSettings.get('savedObjects:perPage');
this.pagination = {
initialPageIndex: 0,
initialPageSize,
pageSizeOptions: _.uniq([10, 20, 50, initialPageSize]).sort(),
};
this.state = {
items: [],
totalItems: 0,
@ -62,8 +69,6 @@ class TableListViewUi extends React.Component {
showLimitError: false,
filter: this.props.initialFilter,
selectedIds: [],
page: 0,
perPage: 20,
};
}
@ -309,13 +314,6 @@ class TableListViewUi extends React.Component {
}
renderTable() {
const pagination = {
pageIndex: this.state.page,
pageSize: this.state.perPage,
totalItemCount: this.state.items.length,
pageSizeOptions: PAGE_SIZE_OPTIONS,
};
const selection = this.props.deleteItems ? {
onSelectionChange: (selection) => {
this.setState({
@ -368,7 +366,7 @@ class TableListViewUi extends React.Component {
itemId="id"
items={this.state.items}
columns={columns}
pagination={pagination}
pagination={this.pagination}
loading={this.state.isFetchingItems}
message={noItemsMessage}
selection={selection}