maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[Graph] Fix fields clearing within the Editor (#96767)

Browse source 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Marco Liberati 2021-04-15 18:56:33 +02:00 committed by GitHub
parent 53e2d5d725
commit 83831ce990
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
x-pack/plugins/graph/public/components/field_manager/field_editor.tsx
View file

@ -71,6 +71,14 @@ export function FieldEditor({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [initialField]);
// In case of cleared field and the user closes the popover, restore the initial field
useEffect(() => {
if (!open) {
setCurrentField(initialField);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [open]);
function updateField() {
const { name, selected, type, ...updatableProperties } = currentField;
if (fieldName !== initialField.name) {
@ -218,8 +226,8 @@ export function FieldEditor({
>
<EuiComboBox
onChange={(choices) => {
// value is always defined because it's an unclearable single selection
const newFieldName = choices[0].value!;
// when user hits backspace the selection gets cleared, so prevent it from breaking
const newFieldName = choices.length ? choices[0].value! : '';
updateProp('name', newFieldName);
}}
@ -357,7 +365,7 @@ export function FieldEditor({
<EuiButton
size="s"
fill
disabled={isEqual(initialField, currentField)}
disabled={isEqual(initialField, currentField) || currentField.name === ''}
onClick={updateField}
>
{i18n.translate('xpack.graph.fieldManager.updateLabel', {