diff --git a/src/plugins/data/public/ui/filter_bar/filter_bar.tsx b/src/plugins/data/public/ui/filter_bar/filter_bar.tsx index 09fd818f2370..8abf6a41d876 100644 --- a/src/plugins/data/public/ui/filter_bar/filter_bar.tsx +++ b/src/plugins/data/public/ui/filter_bar/filter_bar.tsx @@ -55,6 +55,8 @@ function FilterBarUI(props: Props) { } } + const onAddFilterClick = () => setIsAddFilterPopoverOpen(!isAddFilterPopoverOpen); + function renderItems() { return props.filters.map((filter, i) => ( @@ -81,7 +83,7 @@ function FilterBarUI(props: Props) { const button = ( setIsAddFilterPopoverOpen(true)} + onClick={onAddFilterClick} data-test-subj="addFilter" className="globalFilterBar__addButton" > diff --git a/test/accessibility/apps/filter_panel.ts b/test/accessibility/apps/filter_panel.ts index 78e776ce3a48..deb1e9512cd8 100644 --- a/test/accessibility/apps/filter_panel.ts +++ b/test/accessibility/apps/filter_panel.ts @@ -24,6 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { it('a11y test on add filter panel', async () => { await PageObjects.discover.openAddFilterPanel(); await a11y.testAppSnapshot(); + await PageObjects.discover.closeAddFilterPanel(); await filterBar.addFilter('OriginCityName', 'is', 'Rome'); }); diff --git a/test/functional/page_objects/discover_page.ts b/test/functional/page_objects/discover_page.ts index a45c1a23ed3a..fa7aee4e3c54 100644 --- a/test/functional/page_objects/discover_page.ts +++ b/test/functional/page_objects/discover_page.ts @@ -83,6 +83,10 @@ export class DiscoverPageObject extends FtrService { await this.testSubjects.click('addFilter'); } + public async closeAddFilterPanel() { + await this.testSubjects.click('addFilter'); + } + public async waitUntilSearchingHasFinished() { await this.testSubjects.missingOrFail('loadingSpinner', { timeout: this.defaultFindTimeout * 10, diff --git a/test/functional/services/filter_bar.ts b/test/functional/services/filter_bar.ts index 1d0b85eed3a9..5d189506c314 100644 --- a/test/functional/services/filter_bar.ts +++ b/test/functional/services/filter_bar.ts @@ -199,5 +199,6 @@ export class FilterBarService extends FtrService { public async selectIndexPattern(indexPatternTitle: string): Promise { await this.testSubjects.click('addFilter'); await this.comboBox.set('filterIndexPatternsSelect', indexPatternTitle); + await this.testSubjects.click('addFilter'); } }