maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

add aria-label to select without label (#19830)

Browse source
This commit is contained in:
Nathan Reese 2018-06-12 13:16:00 -06:00 committed by GitHub
parent 647d3366eb
commit 87dbcdbede
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/core_plugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.js.snap
View file

@ -98,6 +98,7 @@ exports[`renders ControlsTab 1`] = `
id="selectControlType"
>
<EuiSelect
aria-label="Select control type"
compressed={false}
fullWidth={false}
hasNoInitialSelection={false}
@ -130,6 +131,7 @@ exports[`renders ControlsTab 1`] = `
id="addControl"
>
<EuiButton
aria-label="Add control"
color="primary"
data-test-subj="inputControlEditorAddBtn"
fill={true}

2
src/core_plugins/input_control_vis/public/components/editor/controls_tab.js
View file

@ -157,6 +157,7 @@ export class ControlsTab extends Component {
]}
value={this.state.type}
onChange={evt => this.setState({ type: evt.target.value })}
aria-label="Select control type"
/>
</EuiFormRow>
</EuiFlexItem>
@ -169,6 +170,7 @@ export class ControlsTab extends Component {
onClick={this.handleAddControl}
iconType="plusInCircle"
data-test-subj="inputControlEditorAddBtn"
aria-label="Add control"
>
Add
</EuiButton>