From 895aad24b1e9f58ace691fc52ed0a04802af0833 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Wed, 6 Oct 2021 08:45:38 -0400
Subject: [PATCH] Uncomment missing feature privileges message (#113954)
 (#114072)

Co-authored-by: Dmitry Shevchenko <dmshevch@gmail.com>
---
 .../translations.tsx                          | 60 ++++++++-----------
 1 file changed, 26 insertions(+), 34 deletions(-)

diff --git a/x-pack/plugins/security_solution/public/detections/components/callouts/missing_privileges_callout/translations.tsx b/x-pack/plugins/security_solution/public/detections/components/callouts/missing_privileges_callout/translations.tsx
index 0d628d89c092..1468f4c00d50 100644
--- a/x-pack/plugins/security_solution/public/detections/components/callouts/missing_privileges_callout/translations.tsx
+++ b/x-pack/plugins/security_solution/public/detections/components/callouts/missing_privileges_callout/translations.tsx
@@ -56,7 +56,7 @@ export const missingPrivilegesCallOutBody = ({
 }: MissingPrivileges) => (
   <FormattedMessage
     id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.messageDetail"
-    defaultMessage="{essence} {indexPrivileges} Related documentation: {docs}"
+    defaultMessage="{essence} {indexPrivileges} {featurePrivileges} Related documentation: {docs}"
     values={{
       essence: (
         <p>
@@ -77,30 +77,23 @@ export const missingPrivilegesCallOutBody = ({
               {indexPrivileges.map(([index, missingPrivileges]) => (
                 <li key={index}>{missingIndexPrivileges(index, missingPrivileges)}</li>
               ))}
-              {
-                // TODO: Uncomment once RBAC for alerts is reenabled
-                /* {featurePrivileges.map(([feature, missingPrivileges]) => (
-                <li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
-              ))} */
-              }
             </ul>
           </>
         ) : null,
-      // TODO: Uncomment once RBAC for alerts is reenabled
-      // featurePrivileges:
-      //   featurePrivileges.length > 0 ? (
-      //     <>
-      //       <FormattedMessage
-      //         id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.featurePrivilegesTitle"
-      //         defaultMessage="Missing Kibana feature privileges:"
-      //       />
-      //       <ul>
-      //         {featurePrivileges.map(([feature, missingPrivileges]) => (
-      //           <li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
-      //         ))}
-      //       </ul>
-      //     </>
-      //   ) : null,
+      featurePrivileges:
+        featurePrivileges.length > 0 ? (
+          <>
+            <FormattedMessage
+              id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.featurePrivilegesTitle"
+              defaultMessage="Missing Kibana feature privileges:"
+            />
+            <ul>
+              {featurePrivileges.map(([feature, missingPrivileges]) => (
+                <li key={feature}>{missingFeaturePrivileges(feature, missingPrivileges)}</li>
+              ))}
+            </ul>
+          </>
+        ) : null,
       docs: (
         <ul>
           <li>
@@ -159,15 +152,14 @@ const missingIndexPrivileges = (index: string, privileges: string[]) => (
   />
 );
 
-// TODO: Uncomment once RBAC for alerts is reenabled
-// const missingFeaturePrivileges = (feature: string, privileges: string[]) => (
-//   <FormattedMessage
-//     id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.missingFeaturePrivileges"
-//     defaultMessage="Missing {privileges} privileges for the {index} feature. {explanation}"
-//     values={{
-//       privileges: <CommaSeparatedValues values={privileges} />,
-//       index: <EuiCode>{feature}</EuiCode>,
-//       explanation: getPrivilegesExplanation(privileges, feature),
-//     }}
-//   />
-// );
+const missingFeaturePrivileges = (feature: string, privileges: string[]) => (
+  <FormattedMessage
+    id="xpack.securitySolution.detectionEngine.missingPrivilegesCallOut.messageBody.missingFeaturePrivileges"
+    defaultMessage="Missing {privileges} privileges for the {index} feature. {explanation}"
+    values={{
+      privileges: <CommaSeparatedValues values={privileges} />,
+      index: <EuiCode>{feature}</EuiCode>,
+      explanation: getPrivilegesExplanation(privileges, feature),
+    }}
+  />
+);