From 89dc4f2e007afda638a51af7ccc4ee24cf4c21a5 Mon Sep 17 00:00:00 2001 From: Vadim Dalecky Date: Mon, 18 Jan 2021 21:05:29 +0100 Subject: [PATCH] =?UTF-8?q?test:=20=F0=9F=92=8D=20enable=20URL=20drilldown?= =?UTF-8?q?=20test=20(#88580)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../url_drilldown_collect_config.tsx | 2 ++ .../apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/components/url_drilldown_collect_config/url_drilldown_collect_config.tsx b/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/components/url_drilldown_collect_config/url_drilldown_collect_config.tsx index 04ed73b2ce0b..e381a55397c3 100644 --- a/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/components/url_drilldown_collect_config/url_drilldown_collect_config.tsx +++ b/x-pack/plugins/ui_actions_enhanced/public/drilldowns/url_drilldown/components/url_drilldown_collect_config/url_drilldown_collect_config.tsx @@ -121,6 +121,7 @@ export const UrlDrilldownCollectConfig: React.FC = ({ @@ -131,6 +132,7 @@ export const UrlDrilldownCollectConfig: React.FC = ({ label={txtUrlTemplateOpenInNewTab} checked={config.openInNewTab} onChange={() => onConfig({ ...config, openInNewTab: !config.openInNewTab })} + data-test-subj="urlDrilldownOpenInNewTab" /> diff --git a/x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts b/x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts index d44a373f4304..fe2d947cb642 100644 --- a/x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts +++ b/x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown.ts @@ -25,7 +25,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.dashboard.preserveCrossAppState(); }); - it.skip('should create dashboard to URL drilldown and use it to navigate to discover', async () => { + it('should create dashboard to URL drilldown and use it to navigate to discover', async () => { await PageObjects.dashboard.gotoDashboardEditMode( dashboardDrilldownsManage.DASHBOARD_WITH_AREA_CHART_NAME ); @@ -43,6 +43,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { destinationURLTemplate: urlTemplate, trigger: 'SELECT_RANGE_TRIGGER', }); + + await testSubjects.click('urlDrilldownAdditionalOptions'); + await testSubjects.click('urlDrilldownOpenInNewTab'); + await dashboardDrilldownsManage.saveChanges(); await dashboardDrilldownsManage.expectsCreateDrilldownFlyoutClose();