maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Correctly type ILM's optional dependencies as optional (#63255)

Browse source 
And guard against their absence.
This commit is contained in:
CJ Cenizal 2020-04-10 12:05:20 -07:00 committed by GitHub
parent d8a295dcbc
commit 8a283de3c5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
x-pack/plugins/index_lifecycle_management/public/application/services/ui_metric.ts
View file

@ -23,10 +23,12 @@ import {
import { defaultColdPhase, defaultWarmPhase, defaultHotPhase } from '../store/defaults';
export let trackUiMetric: (metricType: UiStatsMetricType, eventName: string) => void;
export let trackUiMetric = (metricType: UiStatsMetricType, eventName: string) => {};
export function init(usageCollection: UsageCollectionSetup): void {
trackUiMetric = usageCollection.reportUiStats.bind(usageCollection, UIM_APP_NAME);
export function init(usageCollection?: UsageCollectionSetup): void {
if (usageCollection) {
trackUiMetric = usageCollection.reportUiStats.bind(usageCollection, UIM_APP_NAME);
}
}
export function getUiMetricsForPhases(phases: any): any {

2
x-pack/plugins/index_lifecycle_management/public/types.ts
View file

@ -9,7 +9,7 @@ import { ManagementSetup } from '../../../../src/plugins/management/public';
import { IndexManagementPluginSetup } from '../../index_management/public';
export interface PluginsDependencies {
usageCollection: UsageCollectionSetup;
usageCollection?: UsageCollectionSetup;
management: ManagementSetup;
indexManagement?: IndexManagementPluginSetup;
}

2
x-pack/plugins/index_lifecycle_management/server/plugin.ts
View file

@ -75,7 +75,7 @@ export class IndexLifecycleManagementServerPlugin implements Plugin<void, void,
});
if (config.ui.enabled) {
if (indexManagement.indexDataEnricher) {
if (indexManagement && indexManagement.indexDataEnricher) {
indexManagement.indexDataEnricher.add(indexLifecycleDataEnricher);
}
}

2
x-pack/plugins/index_lifecycle_management/server/types.ts
View file

@ -14,7 +14,7 @@ import { isEsError } from './lib/is_es_error';
export interface Dependencies {
licensing: LicensingPluginSetup;
indexManagement: IndexManagementPluginSetup;
indexManagement?: IndexManagementPluginSetup;
}
export interface RouteDependencies {